Skip to content

Commit 090c430

Browse files
committed
Fix: task completed function
1 parent 515814c commit 090c430

File tree

1 file changed

+23
-3
lines changed

1 file changed

+23
-3
lines changed

script.js

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,28 @@ const taskUncompletedIcon = "fa-regular fa-circle pendingSvg";
88

99
const completedTask = (task) => {
1010

11-
// if the task sign is uncheck then check it, visa-versa
12-
task.className = task.className === taskUncompletedIcon ? taskCompletedIcon : taskUncompletedIcon;
11+
const uncheckIcon = task.querySelector("i.pendingSvg");
12+
const editIcon = task.querySelector("i.editSvg");
13+
14+
if(uncheckIcon.className === taskUncompletedIcon)
15+
{
16+
// update icon, disable edit
17+
uncheckIcon.className = taskCompletedIcon;
18+
editIcon.style.display = "none";
19+
task.classList.add("checked");
20+
21+
// shift the completed task to the end
22+
const shiftTask = task.cloneNode(true);
23+
task.remove();
24+
taskContainer.append(shiftTask);
25+
}
26+
else
27+
{
28+
// update icon, enable edit
29+
uncheckIcon.className = taskUncompletedIcon;
30+
editIcon.style.display = "block";
31+
task.classList.remove("checked");
32+
}
1333
}
1434

1535
const editTaskText = (task) => {
@@ -57,7 +77,7 @@ taskContainer.addEventListener("click", (e) => {
5777
switch(data)
5878
{
5979
case 'check':
60-
completedTask(clickedElement);
80+
completedTask(taskElement);
6181
break;
6282
case 'task':
6383
break;

0 commit comments

Comments
 (0)