Authlogic is incompatible with Minitest v5.19.0 and later

[toncid]

ISSUES THAT DO NOT FOLLOW THIS TEMPLATE WILL BE CLOSED IMMEDIATELY.

• This is not a usage question.
  • Our volunteers' time is limited, so please ask usage questions on StackOverflow.
• This is not a security issue.
  • Do not disclose security issues in public. See our contributing guide for instructions.
• This bug is reproducible with a clean install of authlogic
• I am committed to fixing this in a reasonable amount of time, and responding promptly to feedback.

Expected Behavior

The authlogic/test_case.rb should be extended with the following includes:

module Authlogic
  module TestCase
    ...
  end

  ...

  # new includes
  ::Minitest::Unit::TestCase.send(:include, TestCase) if defined?(::Minitest::Unit::TestCase)
  ::Minitest::Test.send(:include, TestCase) if defined?(::Minitest::Test)
end

Actual Behavior

Tests fail because Minitest removed a legacy compatibility layer in v5.19.0 and test classes are no longer included.

[ceneon]

I'm having some trouble running tests on a Rails app that I'm upgrading from Rails 5 to Rails 7 and ended up here. Authlogic gets in between of some ActiveAdmin classes and breaks everything.

I thought these includes you propose may be missing, but I see them in Authlogic's code already -> https://github.com/binarylogic/authlogic/blame/master/lib/authlogic/test_case.rb#L213

[toncid]

Yes, the fix should be simple and something like:

module Authlogic
  ...

  if defined?(::Minitest)
    ::Minitest::Unit::TestCase.send(:include, TestCase) if defined?(::Minitest::Unit::TestCase)
    ::Minitest::Test.send(:include, TestCase) if defined?(::Minitest::Test)
  elsif defined?(::MiniTest) # for Minitest < 5.19.0
    ::MiniTest::Unit::TestCase.send(:include, TestCase) if defined?(::MiniTest::Unit::TestCase)
    ::MiniTest::Test.send(:include, TestCase) if defined?(::MiniTest::Test)
  end
end

[robinjfisher]

Thank you for this. Ended up here also following an early Rails 6 to Rails 7 upgrade path. My specific issue was that I had an "activate_authlogic" method missing error and adding your proposed includes to an initializer fixed the problem.