feat: upgrade to Angular 8 #1386

l-lin · l-lin · commit 52d7f4edb144 · 2019-06-11T16:40:49.000+02:00
diff --git a/DEVELOPER.md b/DEVELOPER.md
@@ -6,7 +6,7 @@ Node.js and npm are essential to Angular development.
 
 [Get it now](https://docs.npmjs.com/getting-started/installing-node) if it's not already installed on your machine.
 
-**Verify that you are running at least node `v4.x.x` and npm `3.x.x`**
+**Verify that you are running at least node `v10.x.x` and npm `6.x.x`**
 by running `node -v` and `npm -v` in a terminal/console window.
 Older versions produce errors.
 
diff --git a/demo/package-lock.json b/demo/package-lock.json
diff --git a/demo/package.json b/demo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-datatables-demo",
-  "version": "7.0.1-dev",
+  "version": "8.0.0-dev",
   "license": "MIT",
   "scripts": {
     "ng": "ng",
@@ -12,64 +12,64 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "^7.0.1",
-    "@angular/common": "^7.0.1",
-    "@angular/compiler": "^7.0.1",
-    "@angular/core": "^7.0.1",
-    "@angular/forms": "^7.0.1",
-    "@angular/http": "^7.0.1",
-    "@angular/platform-browser": "^7.0.1",
-    "@angular/platform-browser-dynamic": "^7.0.1",
-    "@angular/router": "^7.0.1",
+    "@angular/animations": "^8.0.0",
+    "@angular/common": "^8.0.0",
+    "@angular/compiler": "^8.0.0",
+    "@angular/core": "^8.0.0",
+    "@angular/forms": "^8.0.0",
+    "@angular/http": "^7.2.15",
+    "@angular/platform-browser": "^8.0.0",
+    "@angular/platform-browser-dynamic": "^8.0.0",
+    "@angular/router": "^8.0.0",
     "angular-datatables": "^7.0.0",
     "angular2-highlight-js": "^6.0.1-alpha",
-    "core-js": "^2.5.4",
-    "datatables.net": "^1.10.16",
-    "datatables.net-buttons": "^1.4.2",
-    "datatables.net-buttons-dt": "^1.4.2",
-    "datatables.net-colreorder": "^1.4.1",
-    "datatables.net-colreorder-dt": "^1.4.1",
-    "datatables.net-dt": "^1.10.16",
-    "datatables.net-responsive": "^2.2.0",
-    "datatables.net-responsive-dt": "^2.2.0",
-    "datatables.net-scroller": "^1.4.3",
-    "datatables.net-select": "^1.2.3",
-    "datatables.net-select-dt": "^1.2.3",
-    "highlight.js": "^9.12.0",
-    "jquery": "^3.2.1",
-    "jszip": "^3.1.5",
+    "core-js": "^3.1.3",
+    "datatables.net": "^1.10.19",
+    "datatables.net-buttons": "^1.5.6",
+    "datatables.net-buttons-dt": "^1.5.6",
+    "datatables.net-colreorder": "^1.5.1",
+    "datatables.net-colreorder-dt": "^1.5.1",
+    "datatables.net-dt": "^1.10.19",
+    "datatables.net-responsive": "^2.2.3",
+    "datatables.net-responsive-dt": "^2.2.3",
+    "datatables.net-scroller": "^2.0.0",
+    "datatables.net-select": "^1.3.0",
+    "datatables.net-select-dt": "^1.3.0",
+    "highlight.js": "^9.15.8",
+    "jquery": "^3.4.1",
+    "jszip": "^3.2.1",
     "materialize-css": "0.100.2",
-    "rxjs": "^6.3.3",
-    "rxjs-compat": "^6.1.0",
-    "tether": "^1.4.0",
+    "rxjs": "^6.5.2",
+    "rxjs-compat": "^6.5.2",
+    "tether": "^1.4.6",
     "ts-helpers": "^1.1.2",
-    "zone.js": "^0.8.26"
+    "zone.js": "^0.9.1"
   },
   "devDependencies": {
-    "@angular/cli": "^7.0.3",
-    "@angular/compiler-cli": "^7.0.1",
-    "@angular/language-service": "^7.0.1",
-    "@angular-devkit/build-angular": "~0.10.3",
-    "@types/datatables.net": "^1.10.6",
-    "@types/datatables.net-buttons": "^1.1.4",
-    "@types/datatables.net-select": "^1.2.2",
-    "@types/jasmine": "~2.8.7",
-    "@types/jasminewd2": "~2.0.3",
-    "@types/jquery": "~3.3.22",
-    "@types/node": "~10.12.0",
-    "chalk": "~2.4.1",
-    "codelyzer": "^4.0.1",
-    "jasmine-core": "~3.3.0",
+    "@angular/cli": "^8.0.2",
+    "@angular/compiler-cli": "^8.0.0",
+    "@angular/language-service": "^8.0.0",
+    "@angular-devkit/build-angular": "~0.800.2",
+    "@types/datatables.net": "^1.10.17",
+    "@types/datatables.net-buttons": "^1.4.2",
+    "@types/datatables.net-select": "^1.2.5",
+    "@types/jasmine": "~3.3.13",
+    "@types/jasminewd2": "~2.0.6",
+    "@types/jquery": "~3.3.29",
+    "@types/node": "~12.0.7",
+    "chalk": "~2.4.2",
+    "codelyzer": "^5.1.0",
+    "jasmine-core": "~3.4.0",
     "jasmine-spec-reporter": "~4.2.1",
-    "karma": "~3.1.1",
+    "karma": "~4.1.0",
     "karma-chrome-launcher": "~2.2.0",
-    "karma-coverage-istanbul-reporter": "^2.0.4",
-    "karma-jasmine": "~1.1.1",
-    "karma-jasmine-html-reporter": "^1.3.1",
-    "protractor": "~5.4.1",
-    "ts-node": "~7.0.1",
-    "tslint": "~5.11.0",
-    "typescript": "~3.1.3"
+    "karma-coverage-istanbul-reporter": "^2.0.5",
+    "karma-jasmine": "~2.0.1",
+    "karma-jasmine-html-reporter": "^1.4.2",
+    "protractor": "~5.4.2",
+    "ts-node": "~8.2.0",
+    "tslint": "~5.17.0",
+    "typescript": "~3.4.5"
   },
   "engines": {
     "node": ">=8.9.0"
diff --git a/demo/src/app/advanced/custom-range-search-snippet.component.ts b/demo/src/app/advanced/custom-range-search-snippet.component.ts
@@ -44,7 +44,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'custom-range-search.component.html'
 })
 export class CustomRangeSearchComponent implements OnDestroy, OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   datatableElement: DataTableDirective;
   min: number;
   max: number;
diff --git a/demo/src/app/advanced/custom-range-search.component.ts b/demo/src/app/advanced/custom-range-search.component.ts
@@ -8,7 +8,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'custom-range-search.component.html'
 })
 export class CustomRangeSearchComponent implements OnDestroy, OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   datatableElement: DataTableDirective;
   min: number;
   max: number;
@@ -50,9 +50,10 @@ export class CustomRangeSearchComponent implements OnDestroy, OnInit {
     $.fn['dataTable'].ext.search.pop();
   }
 
-  filterById(): void {
+  filterById(): boolean {
     this.datatableElement.dtInstance.then((dtInstance: DataTables.Api) => {
       dtInstance.draw();
     });
+    return false;
   }
 }
diff --git a/demo/src/app/advanced/dt-instance-snippet.component.ts b/demo/src/app/advanced/dt-instance-snippet.component.ts
@@ -43,7 +43,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'dt-instance.component.html'
 })
 export class DtInstanceComponent implements OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   private datatableElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/advanced/dt-instance.component.ts b/demo/src/app/advanced/dt-instance.component.ts
@@ -7,7 +7,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'dt-instance.component.html'
 })
 export class DtInstanceComponent implements OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   datatableElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/advanced/individual-column-filtering-snippet.component.ts b/demo/src/app/advanced/individual-column-filtering-snippet.component.ts
@@ -39,7 +39,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'individual-column-filtering.component.html'
 })
 export class IndividualColumnFilteringComponent implements OnInit, AfterViewInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   datatableElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/advanced/individual-column-filtering.component.ts b/demo/src/app/advanced/individual-column-filtering.component.ts
@@ -7,7 +7,7 @@ import { DataTableDirective } from 'angular-datatables';
   templateUrl: 'individual-column-filtering.component.html'
 })
 export class IndividualColumnFilteringComponent implements OnInit, AfterViewInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   datatableElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/advanced/rerender-snippet.component.ts b/demo/src/app/advanced/rerender-snippet.component.ts
@@ -36,7 +36,7 @@ import { Subject } from 'rxjs';
   templateUrl: 'rerender.component.html'
 })
 export class RerenderComponent implements AfterViewInit, OnDestroy, OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   dtElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/advanced/rerender.component.ts b/demo/src/app/advanced/rerender.component.ts
@@ -7,7 +7,7 @@ import { Subject } from 'rxjs';
   templateUrl: 'rerender.component.html'
 })
 export class RerenderComponent implements AfterViewInit, OnDestroy, OnInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, {static: false})
   dtElement: DataTableDirective;
 
   dtOptions: DataTables.Settings = {};
diff --git a/demo/src/app/getting-started.component.ts b/demo/src/app/getting-started.component.ts
@@ -7,7 +7,7 @@ import { Component } from '@angular/core';
 export class GettingStartedComponent {
   nodeVersion = '8.9';
   npmVersion = '6';
-  angularCliVersion = '7.Y.Z';
+  angularCliVersion = '8.Y.Z';
   npmInstallSnippet = `
 <pre>
 <code class="bash highlight">npm install jquery --save
diff --git a/demo/src/polyfills.ts b/demo/src/polyfills.ts
@@ -11,58 +11,53 @@
  * automatically update themselves. This includes Safari >= 10, Chrome >= 55 (including Opera),
  * Edge >= 13 on the desktop, and iOS 10 and Chrome on mobile.
  *
- * Learn more in https://angular.io/docs/ts/latest/guide/browser-support.html
+ * Learn more in https://angular.io/guide/browser-support
  */
 
 /***************************************************************************************************
  * BROWSER POLYFILLS
  */
 
-/** IE9, IE10 and IE11 requires all of the following polyfills. **/
-// import 'core-js/es6/symbol';
-// import 'core-js/es6/object';
-// import 'core-js/es6/function';
-// import 'core-js/es6/parse-int';
-// import 'core-js/es6/parse-float';
-// import 'core-js/es6/number';
-// import 'core-js/es6/math';
-// import 'core-js/es6/string';
-// import 'core-js/es6/date';
-// import 'core-js/es6/array';
-// import 'core-js/es6/regexp';
-// import 'core-js/es6/map';
-// import 'core-js/es6/set';
-
 /** IE10 and IE11 requires the following for NgClass support on SVG elements */
 // import 'classlist.js';  // Run `npm install --save classlist.js`.
 
-/** IE10 and IE11 requires the following to support `@angular/animation`. */
-// import 'web-animations-js';  // Run `npm install --save web-animations-js`.
-
-
-/** Evergreen browsers require these. **/
-import 'core-js/es6/reflect';
-import 'core-js/es7/reflect';
-
-
-/** ALL Firefox browsers require the following to support `@angular/animation`. **/
+/**
+ * Web Animations `@angular/platform-browser/animations`
+ * Only required if AnimationBuilder is used within the application and using IE/Edge or Safari.
+ * Standard animation support in Angular DOES NOT require any polyfills (as of Angular 6.0).
+ */
 // import 'web-animations-js';  // Run `npm install --save web-animations-js`.
 
-
+/**
+ * By default, zone.js will patch all possible macroTask and DomEvents
+ * user can disable parts of macroTask/DomEvents patch by setting following flags
+ * because those flags need to be set before `zone.js` being loaded, and webpack
+ * will put import in the top of bundle, so user need to create a separate file
+ * in this directory (for example: zone-flags.ts), and put the following flags
+ * into that file, and then add the following code before importing zone.js.
+ * import './zone-flags.ts';
+ *
+ * The flags allowed in zone-flags.ts are listed here.
+ *
+ * The following flags will work for all browsers.
+ *
+ * (window as any).__Zone_disable_requestAnimationFrame = true; // disable patch requestAnimationFrame
+ * (window as any).__Zone_disable_on_property = true; // disable patch onProperty such as onclick
+ * (window as any).__zone_symbol__UNPATCHED_EVENTS = ['scroll', 'mousemove']; // disable patch specified eventNames
+ *
+ *  in IE/Edge developer tools, the addEventListener will also be wrapped by zone.js
+ *  with the following flag, it will bypass `zone.js` patch for IE/Edge
+ *
+ *  (window as any).__Zone_enable_cross_context_check = true;
+ *
+ */
 
 /***************************************************************************************************
- * Zone JS is required by Angular itself.
+ * Zone JS is required by default for Angular itself.
  */
 import 'zone.js/dist/zone';  // Included with Angular CLI.
 
 
-
 /***************************************************************************************************
  * APPLICATION IMPORTS
  */
-
-/**
- * Date, currency, decimal and percent pipes.
- * Needed for: All but Chrome, Firefox, Edge, IE11 and Safari 10
- */
-// import 'intl';  // Run `npm install --save intl`.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
diff --git a/rollup-uglify.conf.js b/rollup-uglify.conf.js
diff --git a/tsconfig.json b/tsconfig.json
diff --git a/tslint.json b/tslint.json

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import { DataTableDirective } from 'angular-datatables';`
`8`	`8`	`templateUrl: 'custom-range-search.component.html'`
`9`	`9`	`})`
`10`	`10`	`export class CustomRangeSearchComponent implements OnDestroy, OnInit {`
`11`		`- @ViewChild(DataTableDirective)`
	`11`	`+ @ViewChild(DataTableDirective, {static: false})`
`12`	`12`	`datatableElement: DataTableDirective;`
`13`	`13`	`min: number;`
`14`	`14`	`max: number;`
`@@ -50,9 +50,10 @@ export class CustomRangeSearchComponent implements OnDestroy, OnInit {`
`50`	`50`	`$.fn['dataTable'].ext.search.pop();`
`51`	`51`	`}`
`52`	`52`
`53`		`- filterById(): void {`
	`53`	`+ filterById(): boolean {`
`54`	`54`	`this.datatableElement.dtInstance.then((dtInstance: DataTables.Api) => {`
`55`	`55`	`dtInstance.draw();`
`56`	`56`	`});`
	`57`	`+ return false;`
`57`	`58`	`}`
`58`	`59`	`}`