terminal: setup LND prior to stores

In the upcoming actions migration, we need fetch LNDs macaroons prior to
initializing the stores, as the macaroons will be required during the
migration.

This requires that we setup the connection to LND before we initialize
the stores, as we can only fetch the macaroons after the LND connection
is established.

This commit refactors the litd startup process, so that the stores are
initialized after the LND connection is established.

Author: ViktorTigerstrom

terminal.go

@@ -447,22 +447,6 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 		return fmt.Errorf("could not create network directory: %v", err)
 	}
 
-	g.stores, err = NewStores(g.cfg, clock.NewDefaultClock())
-	if err != nil {
-		return fmt.Errorf("could not create stores: %v", err)
-	}
-
-	if err := g.stores.firewall.Start(ctx); err != nil {
-		return fmt.Errorf("could not start firewall DB: %v", err)
-	}
-
-	g.accountService, err = accounts.NewService(
-		g.stores.accounts, accountServiceErrCallback,
-	)
-	if err != nil {
-		return fmt.Errorf("error creating account service: %v", err)
-	}
-
 	// We create a reference to the `accountRpcServer` here before starting
 	// it and prior to setting up the LND connection. This is because when
 	// the LND connection is set up for an integrated LND instance, LND will
@@ -750,6 +734,27 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	// lnd clients.
 	g.statusMgr.SetRunning(subservers.LND)
 
+	g.stores, err = NewStores(g.cfg, clock.NewDefaultClock())
+	if err != nil {
+		return fmt.Errorf("could not create stores: %v", err)
+	}
+
+	if err := g.stores.firewall.Start(ctx); err != nil {
+		return fmt.Errorf("could not start firewall DB: %v", err)
+	}
+
+	g.accountService, err = accounts.NewService(
+		g.stores.accounts, accountServiceErrCallback,
+	)
+	if err != nil {
+		return fmt.Errorf("error creating account service: %v", err)
+	}
+
+	if err != nil {
+		return fmt.Errorf("could not create new session rpc "+
+			"server: %v", err)
+	}
+
 	// Both connection types are ready now, let's start our sub-servers if
 	// they should be started locally as an integrated service.
 	createDefaultMacaroons := !g.cfg.statelessInitMode