Fix property inconsistency with generics

Author: sayuprc

src/Analyser/NodeScopeResolver.php

@@ -651,7 +651,7 @@ private function processStmtNode(
 			$throwPoints = [];
 			$impurePoints = [];
 			$this->processAttributeGroups($stmt, $stmt->attrGroups, $scope, $nodeCallback);
-			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);
+			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, $isReadOnly, $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);
 
 			foreach ($stmt->params as $param) {
 				$this->processParamNode($stmt, $param, $scope, $nodeCallback);
@@ -718,7 +718,7 @@ private function processStmtNode(
 						true,
 						$isFromTrait,
 						$param,
-						false,
+						$isReadOnly,
 						$scope->isInTrait(),
 						$classReflection->isReadOnly(),
 						false,

tests/PHPStan/Analyser/Bug13049Test.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Rules\Generics\PropertyVarianceRule;
+use PHPStan\Rules\Generics\VarianceCheck;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<PropertyVarianceRule>
+ */
+class Bug13049Test extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new PropertyVarianceRule(new VarianceCheck());
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13049.php'], []);
+	}
+
+}

tests/PHPStan/Analyser/data/bug-13049.php

@@ -0,0 +1,41 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug13049;
+
+/**
+ * @template-covariant Value of string|list<string>
+ *
+ * @immutable
+ */
+final class LanguageProperty
+{
+
+    /** @var Value */
+    public $value;
+
+    /**
+     * @param Value $value
+     */
+    public function __construct($value)
+    {
+        $this->value = $value;
+    }
+}
+
+/**
+ * @template-covariant Value of string|list<string>
+ *
+ * @immutable
+ */
+final class LanguageProperty2
+{
+    /**
+     * @param Value $value
+     */
+    public function __construct(public $value)
+    {
+        $this->value = $value;
+    }
+}