refactor: remove start loop

morlay · morlay · commit 3512fbb3219a · 2020-05-14T11:42:07.000+08:00
diff --git a/pipeline/pipeline_.go b/pipeline/pipeline_.go
@@ -50,10 +50,8 @@ type Pipeline struct {
 
 func (p *Pipeline) Start() error {
 	for name, step := range p.spec.Stages {
-		for i := 0; i < 3; i++ {
-			if err := p.mgr.operatorMgr.Up(p.taskMeta.Scope, name, step, 3); err != nil {
-				return err
-			}
+		if err := p.mgr.operatorMgr.Up(p.taskMeta.Scope, name, step, 3); err != nil {
+			return err
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,8 @@ type Pipeline struct {`
`50`	`50`
`51`	`51`	`func (p *Pipeline) Start() error {`
`52`	`52`	`for name, step := range p.spec.Stages {`
`53`		`- for i := 0; i < 3; i++ {`
`54`		`- if err := p.mgr.operatorMgr.Up(p.taskMeta.Scope, name, step, 3); err != nil {`
`55`		`- return err`
`56`		`- }`
	`53`	`+ if err := p.mgr.operatorMgr.Up(p.taskMeta.Scope, name, step, 3); err != nil {`
	`54`	`+ return err`
`57`	`55`	`}`
`58`	`56`	`}`
`59`	`57`	`return nil`