Skip to content

Commit 82c18e9

Browse files
committed
Backport publishing metrics to 5.x
Fixes #374
1 parent 0e38d5f commit 82c18e9

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

src/main/java/com/rabbitmq/client/MetricsCollector.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,21 @@ public interface MetricsCollector {
3636

3737
void basicPublish(Channel channel);
3838

39-
void basicPublishFailure(Channel channel, Throwable cause);
39+
default void basicPublishFailure(Channel channel, Throwable cause) {
4040

41-
void basicPublishAck(Channel channel, long deliveryTag, boolean multiple);
41+
}
4242

43-
void basicPublishNack(Channel channel, long deliveryTag, boolean multiple);
43+
default void basicPublishAck(Channel channel, long deliveryTag, boolean multiple) {
4444

45-
void basicPublishUnrouted(Channel channel);
45+
}
46+
47+
default void basicPublishNack(Channel channel, long deliveryTag, boolean multiple) {
48+
49+
}
50+
51+
default void basicPublishUnrouted(Channel channel) {
52+
53+
}
4654

4755
void consumedMessage(Channel channel, long deliveryTag, boolean autoAck);
4856

src/main/java/com/rabbitmq/client/impl/AbstractMetricsCollector.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ public void basicPublishNack(Channel channel, long deliveryTag, boolean multiple
140140
@Override
141141
public void basicPublishUnrouted(Channel channel) {
142142
try {
143-
markPublishedMessageNotRouted();
143+
markPublishedMessageUnrouted();
144144
} catch(Exception e) {
145-
LOGGER.info("Error while computing metrics in markPublishedMessageNotRouted: " + e.getMessage());
145+
LOGGER.info("Error while computing metrics in markPublishedMessageUnrouted: " + e.getMessage());
146146
}
147147
}
148148

@@ -407,5 +407,5 @@ private ChannelState(Channel channel) {
407407
/**
408408
* Marks the event of a published message not being routed.
409409
*/
410-
protected abstract void markPublishedMessageNotRouted();
410+
protected abstract void markPublishedMessageUnrouted();
411411
}

src/main/java/com/rabbitmq/client/impl/MicrometerMetricsCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ protected void markMessagePublishNotAcknowledged() {
148148
}
149149

150150
@Override
151-
protected void markPublishedMessageNotRouted() {
151+
protected void markPublishedMessageUnrouted() {
152152
unroutedPublishedMessages.increment();
153153
}
154154

src/main/java/com/rabbitmq/client/impl/StandardMetricsCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ protected void markMessagePublishNotAcknowledged() {
125125
}
126126

127127
@Override
128-
protected void markPublishedMessageNotRouted() {
128+
protected void markPublishedMessageUnrouted() {
129129
publishUnroutedMessages.mark();
130130
}
131131

0 commit comments

Comments
 (0)