Skip to content

Commit 9c8db8c

Browse files
Better error messages for topology recovery failures
1 parent 29b4b63 commit 9c8db8c

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,9 @@ private void recoverExchanges() {
431431
try {
432432
x.recover();
433433
} catch (Exception cause) {
434-
TopologyRecoveryException e = new TopologyRecoveryException("Caught an exception while recovering exchange " + x.getName(), cause);
434+
final String message = "Caught an exception while recovering exchange " + x.getName() +
435+
": " + cause.getMessage();
436+
TopologyRecoveryException e = new TopologyRecoveryException(message, cause);
435437
this.getExceptionHandler().handleTopologyRecoveryException(delegate, x.getDelegateChannel(), e);
436438
}
437439
}
@@ -454,7 +456,9 @@ private void recoverQueues() {
454456
this.propagateQueueNameChangeToConsumers(oldName, newName);
455457
}
456458
} catch (Exception cause) {
457-
TopologyRecoveryException e = new TopologyRecoveryException("Caught an exception while recovering queue " + oldName, cause);
459+
final String message = "Caught an exception while recovering queue " + oldName +
460+
": " + cause.getMessage();
461+
TopologyRecoveryException e = new TopologyRecoveryException(message, cause);
458462
this.getExceptionHandler().handleTopologyRecoveryException(delegate, q.getDelegateChannel(), e);
459463
}
460464
}
@@ -465,7 +469,8 @@ private void recoverBindings() {
465469
try {
466470
b.recover();
467471
} catch (Exception cause) {
468-
String message = "Caught an exception while recovering binding between " + b.getSource() + " and " + b.getDestination();
472+
String message = "Caught an exception while recovering binding between " + b.getSource() +
473+
" and " + b.getDestination() + ": " + cause.getMessage();
469474
TopologyRecoveryException e = new TopologyRecoveryException(message, cause);
470475
this.getExceptionHandler().handleTopologyRecoveryException(delegate, b.getDelegateChannel(), e);
471476
}
@@ -486,7 +491,9 @@ private void recoverConsumers() {
486491
this.consumers.put(newTag, consumer);
487492
}
488493
} catch (Exception cause) {
489-
TopologyRecoveryException e = new TopologyRecoveryException("Caught an exception while recovering consumer " + tag, cause);
494+
final String message = "Caught an exception while recovering consumer " + tag +
495+
": " + cause.getMessage();
496+
TopologyRecoveryException e = new TopologyRecoveryException(message, cause);
490497
this.getExceptionHandler().handleTopologyRecoveryException(delegate, consumer.getDelegateChannel(), e);
491498
}
492499
}

0 commit comments

Comments
 (0)