Skip to content

Commit 8b8dfd9

Browse files
authored
Handle ENS resolution errors gracefully (#8045)
1 parent 70e5218 commit 8b8dfd9

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

apps/dashboard/src/@/lib/ens.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,21 @@ export async function resolveEns(
1717
ensName: await resolveName({
1818
address: ensNameOrAddress,
1919
client,
20-
}),
20+
}).catch(() => null),
2121
};
2222
}
2323

2424
if (!isValidENSName(ensNameOrAddress)) {
25-
throw new Error("Invalid ENS name");
25+
return {
26+
address: null,
27+
ensName: null,
28+
};
2629
}
2730

2831
const address = await resolveAddress({
2932
client,
3033
name: ensNameOrAddress,
31-
});
34+
}).catch(() => null);
3235

3336
if (!address) {
3437
return {

packages/thirdweb/src/extensions/erc721/read/getNFT.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("erc721.getNFT", () => {
9393
"name": "Doodle #1",
9494
"uri": "ipfs://QmPMc4tcBsMqLRuCQtPmPe84bpSjrC3Ky7t3JWuHXYB4aS/1",
9595
},
96-
"owner": "0x620b70123fB810F6C653DA7644b5dD0b6312e4D8",
96+
"owner": null,
9797
"tokenAddress": "0x8a90cab2b38dba80c64b7734e58ee1db38b8992e",
9898
"tokenURI": "ipfs://QmPMc4tcBsMqLRuCQtPmPe84bpSjrC3Ky7t3JWuHXYB4aS/1",
9999
"type": "ERC721",

0 commit comments

Comments
 (0)