Skip to content

Commit a724bc3

Browse files
committed
[BLD-247] Add propagation time in domain restrictions in project settings page (#8025)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `bottomText` prop of the `SettingsCard` component in the `ProjectGeneralSettingsPage.tsx` file to provide more detailed information regarding domain restrictions for web applications. ### Detailed summary - Changed `bottomText` from a string to a fragment containing: - A message about applicability for web applications. - An additional note that changes to domain restrictions may take up to 5 minutes to take effect. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Clarified Allowed Domains setting copy to state it's only applicable for web applications. * Added guidance that domain restriction changes may take up to 5 minutes to take effect. * Purely a UI copy update; no functional or behavioral changes. * Improves in-app guidance and reduces configuration confusion. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 2eaff98 commit a724bc3

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/ProjectGeneralSettingsPage.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,12 @@ function AllowedDomainsSetting(props: {
539539

540540
return (
541541
<SettingsCard
542-
bottomText="This is only applicable for web applications"
542+
bottomText={
543+
<>
544+
This is only applicable for web applications. Changes to domain
545+
restrictions may take up to 5 minutes to take effect
546+
</>
547+
}
543548
errorText={form.getFieldState("domains", form.formState).error?.message}
544549
header={{
545550
description:

0 commit comments

Comments
 (0)