fix: qa feedbacks in view scorecard page

Author: hentrymartin

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardDetails/ScorecardDetails.module.scss

@@ -1,3 +1,5 @@
+@import '@libs/ui/styles/includes';
+
 .container {
     display: flex;
     flex-direction: row;
@@ -50,4 +52,10 @@
             flex-direction: column;
         }
     }
+}
+
+@media (max-width: #{$lg-max}) {
+    .container {
+        flex-direction: column;
+    }
 }

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardGroups/ScorecardGroups.module.scss

@@ -37,9 +37,9 @@
         .group {
             .heading {
                 .groupInfo {
-                    flex-direction: column;
+                    flex-direction: row;
                     .name {
-                        margin-bottom: 8px;
+                        margin-bottom: 0px;
                     }
                 }
             }

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardSections/ScorecardSections.module.scss

@@ -80,9 +80,9 @@
         .section {
             .heading {
                 .sectionInfo {
-                    flex-direction: column;
+                    flex-direction: row;
                     .name {
-                        margin-bottom: 4px;
+                        margin-bottom: 0px;
                     }
                 }
             }

src/apps/review/src/pages/scorecards/ViewScorecardPage/ViewScorecardPage.tsx

@@ -20,15 +20,15 @@ const ViewScorecardPage: FC = () => {
     const { profile }: ProfileContextData = useContext(profileContext)
     const isAdmin = profile?.roles.includes(UserRole.administrator)
     const breadCrumb = useMemo(
-        () => [{ index: 1, label: 'Scorecards', path: '/review/scorecard' }, { index: 2, label: 'Scorecards Details' }],
+        () => [{ index: 1, label: 'Scorecards', path: '/scorecard' }, { index: 2, label: 'Scorecards Details' }],
         [],
     )
 
     const scorecardQuery = useFetchScorecard(scorecardId)
 
     return (
         <PageWrapper
-            pageTitle='Software General Review Scorecard'
+            pageTitle={(scorecardQuery.scorecard && scorecardQuery.scorecard.name) || ''}
             breadCrumb={breadCrumb}
             rightHeader={isAdmin && (
                 <LinkButton

src/apps/review/src/review-app.routes.tsx

@@ -101,7 +101,6 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
                 route: activeReviewAssigmentsRouteId,
             },
             {
-                authRequired: true,
                 children: [
                     {
                         authRequired: true,
@@ -110,21 +109,23 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
                         route: '',
                     },
                     {
-                        authRequired: false,
-                        element: <ViewScorecardPage />,
-                        id: 'view-scorecard-page',
-                        route: ':scorecardId',
-                    },
-                    {
+                        authRequired: true,
                         element: <EditScorecardPage />,
                         id: 'edit-scorecard-page',
                         route: ':scorecardId/edit',
                     },
                     {
+                        authRequired: true,
                         element: <EditScorecardPage />,
                         id: 'new-scorecard-page',
                         route: 'new',
                     },
+                    {
+                        authRequired: false,
+                        element: <ViewScorecardPage />,
+                        id: 'view-scorecard-page',
+                        route: ':scorecardId',
+                    },
 
                 ],
                 element: <ScorecardsContainer />,

src/libs/core/lib/router/router-context/router.context-provider.tsx

@@ -99,6 +99,7 @@ export const RouterProvider: FC<RouterProviderProps> = (props: RouterProviderPro
     }
 
     function getRouteElement(route: PlatformRoute): JSX.Element {
+        console.log(route, 'asd.lkasdl')
         // create the route element
         const routeElement: JSX.Element = !route.authRequired
             ? route.element