update validations for scorecard form

Author: vas3a

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardInfoForm.tsx

@@ -28,14 +28,15 @@ export const scorecardInfoSchema = {
         .required('Category is required'),
     maxScore: yup
         .number()
-        .typeError('Max. Score must be a number')
-        .required('Max. Score is required')
-        .moreThan(yup.ref('minScore'), 'Max. Score must be greater than Min. Score'),
+        .typeError('Max score must be a number')
+        .required('Max score is required')
+        .moreThan(yup.ref('minScore'), 'Max score must be greater than min score')
+        .max(100, 'Max score must be lower than 100'),
     minScore: yup
         .number()
-        .typeError('Min. Score must be a number')
-        .required('Min. Score is required')
-        .min(0, 'Min. Score must be at least 0'),
+        .typeError('Min Score must be a number')
+        .required('Min Score is required')
+        .min(0, 'Min Score must be at least 0'),
     name: yup.string()
         .required('Scorecard Name is required'),
     status: yup.string()

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardQuestionForm.tsx

@@ -29,6 +29,15 @@ export const scorecardQuestionSchema = {
                         .required('Description is required'),
                     guidelines: yup.string()
                         .nullable(),
+                    requiresUpload: yup.boolean()
+                        .transform((value, originalValue) => {
+                            // Handle empty string as undefined (so required() can catch it)
+                            if (originalValue === "") return undefined;
+
+                            // Yup already transforms "true"/"false" strings into booleans
+                            return value;
+                        }).required()
+                        .required('Documents requirements is required'),
                     type: yup.string()
                         .required('Scale is required'),
                     weight: yup
@@ -168,7 +177,18 @@ const ScorecardQuestionForm: FC<ScorecardQuestionFormProps> = props => {
                             name={`${name}.${index}.requiresUpload`}
                             placeholder='Select Document Requirements'
                         >
-                            <BasicSelect options={yesNoOptions} />
+                            <BasicSelect
+                                options={yesNoOptions}
+                                onChange={(function handleChangeRequireUpload(
+                                    ev: ChangeEvent<HTMLInputElement>,
+                                    field: any,
+                                ) {
+                                    field.onChange({
+                                        ...ev,
+                                        target: { ...ev.target, value: ev.target.value === 'true' },
+                                    })
+                                }) as ChangeEventHandler}
+                            />
                         </InputWrapper>
                     </div>
                 </div>

src/apps/review/src/pages/scorecards/EditScorecardPage/utils.ts

@@ -7,7 +7,7 @@ import { Scorecard, ScorecardGroup, ScorecardQuestion, ScorecardSection } from '
 export const getEmptyScorecardQuestion = (): ScorecardQuestion => ({
     description: '',
     guidelines: '',
-    requiresUpload: false,
+    requiresUpload: '',
     scaleMax: '',
     scaleMin: '',
     sortOrder: 0,
@@ -61,7 +61,7 @@ export const weightsSum = (
         if (!items?.length) return false
         const sum = items.reduce((acc, g) => acc + (Number(g.weight) || 0), 0)
 
-        if (sum !== 100) {
+        if (sum !== value) {
             // force the error to go into `.root`, otherwise it will overwride the array errors
             return ctx.createError({
                 path: ctx.path.replace(/(\.root$)|$/, '.root'),