Skip to content

Commit 0411b34

Browse files
authored
Merge pull request #773 from topcoder-platform/develop
Fix up invitation by email
2 parents 3c38698 + e0e7a2b commit 0411b34

File tree

4 files changed

+24
-20
lines changed

4 files changed

+24
-20
lines changed

.circleci/config.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
version: 2.1
22
python_env: &python_env
33
docker:
4-
- image: cimg/python:3.11.0-browsers
4+
- image: cimg/python:3.11.7-browsers
55
install_awscli: &install_awscli
66
name: "Install awscli"
77
command: |
88
sudo apt update
9-
sudo apt install jq
10-
sudo apt install python3-pip
9+
sudo apt install jq python3-pip
1110
sudo pip3 install awscli --upgrade
1211
install_deploysuite: &install_deploysuite
1312
name: Installation of install_deploysuite.

config/development.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"connectProjectsUrl": "https://connect.topcoder-dev.com/projects/",
66
"fileServiceEndpoint": "https://api.topcoder-dev.com/v5/files",
77
"memberServiceEndpoint": "https://api.topcoder-dev.com/v5/members",
8-
"identityServiceEndpoint": "https://api.topcoder-dev.com/v3/",
8+
"identityServiceEndpoint": "https://api.topcoder-dev.com/v5/",
99
"taasJobApiUrl": "https://api.topcoder-dev.com/v5/jobs",
1010
"sfdcBillingAccountNameField": "Billing_Account_Name__c",
1111
"sfdcBillingAccountMarkupField": "Mark_Up__c",

package-lock.json

Lines changed: 13 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/routes/projectMemberInvites/create.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,13 @@ module.exports = [
294294
// whom we are inviting, because Member Service has a loose search logic and may return
295295
// users with handles whom we didn't search for
296296
.then((foundUsers) => {
297-
const lowerCaseHandles = invite.handles.map(handle => handle.toLowerCase());
298-
return foundUsers.filter(foundUser => _.includes(lowerCaseHandles, foundUser.handleLower));
297+
if(invite.handles) {
298+
const lowerCaseHandles = invite.handles.map(handle => handle.toLowerCase());
299+
return foundUsers.filter(foundUser => _.includes(lowerCaseHandles, foundUser.handleLower));
300+
}
301+
else {
302+
return []
303+
}
299304
})
300305
.then((inviteUsers) => {
301306
const members = req.context.currentProjectMembers;
@@ -436,6 +441,7 @@ module.exports = [
436441
}
437442
});
438443
}).catch((err) => {
444+
console.log(err)
439445
if (failed.length) {
440446
res.status(403).json(_.assign({}, { success: [] }, { failed }));
441447
} else next(err);

0 commit comments

Comments
 (0)