Skip to content

Commit 9e528d4

Browse files
committed
feat: temporary disable masking emails inside invites
1 parent b1a7346 commit 9e528d4

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/util.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import querystring from 'querystring';
1414
import config from 'config';
1515
import urlencode from 'urlencode';
1616
import elasticsearch from 'elasticsearch';
17-
import jp from 'jsonpath';
17+
// import jp from 'jsonpath';
1818
import Promise from 'bluebird';
1919
import models from './models';
2020

@@ -488,7 +488,16 @@ _.assignIn(util, {
488488
*
489489
* @return {Object} data has been processed
490490
*/
491-
maskInviteEmails: (jsonPath, data, req) => {
491+
maskInviteEmails: (jsonPath, data, req) => { // eslint-disable-line
492+
// temporary disable this feature, because it has some side effects
493+
// see relative issues:
494+
// - https://github.com/topcoder-platform/tc-project-service/issues/420
495+
// - https://github.com/appirio-tech/connect-app/issues/3412
496+
// - https://github.com/topcoder-platform/tc-project-service/issues/422
497+
// - https://github.com/appirio-tech/connect-app/issues/3413
498+
// uncomment code below, to enable masking emails again
499+
500+
/*
492501
const isAdmin = util.hasPermission({ topcoderRoles: ADMIN_ROLES }, req.authUser);
493502
if (isAdmin) {
494503
return data;
@@ -502,6 +511,7 @@ _.assignIn(util, {
502511
// isString or null
503512
return util.maskEmail(value);
504513
});
514+
*/
505515
return data;
506516
},
507517

src/util.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('Util method', () => {
4343
});
4444
});
4545

46-
describe('maskInviteEmails', () => {
46+
xdescribe('maskInviteEmails', () => {
4747
it('should mask emails when passing data like for a project list endpoint for non-admin user', () => {
4848
const list = [
4949
{

0 commit comments

Comments
 (0)