Skip to content

Commit f0337bd

Browse files
authored
Replace package filter icon with text (#10181)
* Replace Filter By icon with text * remove fa reference * Update Button Separation
1 parent 28a416c commit f0337bd

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

src/DynamoCoreWpf/Properties/Resources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DynamoCoreWpf/Properties/Resources.en-US.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2231,4 +2231,7 @@ Uninstall the following packages: {0}?</value>
22312231
<data name="PublishPackageViewPackageHostDependencyTooltip" xml:space="preserve">
22322232
<value>An indication of what applications outside of Dynamo your package depends on, such as Revit, Civil 3D or Photoshop. Users of your package will need to install these applications to fully utilize your package.</value>
22332233
</data>
2234+
<data name="PackageSearchViewFilterByButton" xml:space="preserve">
2235+
<value>Filter by</value>
2236+
</data>
22342237
</root>

src/DynamoCoreWpf/Properties/Resources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2234,4 +2234,7 @@ Uninstall the following packages: {0}?</value>
22342234
<data name="PublishPackageViewPackageHostDependencyTooltip" xml:space="preserve">
22352235
<value>An indication of what applications outside of Dynamo your package depends on, such as Revit, Civil 3D or Photoshop. Users of your package will need to install these applications to fully utilize your package.</value>
22362236
</data>
2237+
<data name="PackageSearchViewFilterByButton" xml:space="preserve">
2238+
<value>Filter by</value>
2239+
</data>
22372240
</root>

src/DynamoCoreWpf/Views/PackageManager/PackageManagerSearchView.xaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
55
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
66
xmlns:ui="clr-namespace:Dynamo.UI"
7-
xmlns:fa="http://schemas.fontawesome.io/icons/"
87
xmlns:p="clr-namespace:Dynamo.Wpf.Properties"
98
xmlns:controls="clr-namespace:Dynamo.Controls"
109
xmlns:viewModels="clr-namespace:Dynamo.PackageManager.ViewModels"
@@ -140,7 +139,7 @@
140139
Grid.Column="0" FontSize ="13" Padding="20,10,5,10" Margin ="0" Background="Transparent" Foreground="#666" IsHitTestVisible="False">
141140
</TextBlock>
142141

143-
<Button Width="auto" MinWidth="100" Grid.Column="1" Click="OnSortButtonClicked"
142+
<Button Width="auto" MinWidth="50" Grid.Column="1" Click="OnSortButtonClicked"
144143
Style="{DynamicResource ResourceKey=STextButton}" Content="{x:Static p:Resources.PackageSearchViewSortByButton}">
145144

146145
<Button.ContextMenu>
@@ -176,11 +175,12 @@
176175
</Button>
177176

178177
<Button Width="Auto"
178+
MinWidth="50"
179179
Grid.Column="2"
180-
Click="OnFilterButtonClicked"
181-
fa:Awesome.Content="Filter"
182-
TextElement.FontFamily="pack://application:,,,/FontAwesome.WPF;component/#FontAwesome"
180+
Click="OnFilterButtonClicked"
181+
Margin="2 0 0 0"
183182
Style="{DynamicResource ResourceKey=STextButton}"
183+
Content="{x:Static p:Resources.PackageSearchViewFilterByButton}"
184184
ToolTip="{x:Static p:Resources.PackageHostDependencyFilter}">
185185
<Button.ContextMenu>
186186
<ContextMenu Name="HostFilter"

0 commit comments

Comments
 (0)