Skip to content

Commit 93c6ffd

Browse files
committed
refactor StreamReadConfig
1 parent a766457 commit 93c6ffd

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

src/main/java/com/fasterxml/jackson/core/StreamReadConfig.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,24 @@ public class StreamReadConfig {
99

1010
private static final int DEFAULT_MAX_NUM_LEN = 1000;
1111

12-
private int _maxNumLen = DEFAULT_MAX_NUM_LEN;
12+
private int _maxNumLen;
13+
14+
public StreamReadConfig() {
15+
_maxNumLen = DEFAULT_MAX_NUM_LEN;
16+
}
17+
18+
private StreamReadConfig(int maxNumLen) {
19+
_maxNumLen = maxNumLen;
20+
}
1321

1422
/**
1523
* Sets the maximum number length (in chars). The default is 1000 (since Jackson 2.14)
1624
* @param maxNumLen the maximum number length (in chars)
1725
* @return this config
1826
* @since 2.15
1927
*/
20-
public StreamReadConfig maxNumberLength(int maxNumLen) {
21-
_maxNumLen = maxNumLen;
22-
return this;
28+
public StreamReadConfig withMaxNumberLength(int maxNumLen) {
29+
return new StreamReadConfig(maxNumLen);
2330
}
2431

2532
public int getMaxNumberLength() {

src/test/java/com/fasterxml/jackson/core/read/NumberOverflowTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class NumberOverflowTest
99
extends com.fasterxml.jackson.core.BaseTest
1010
{
1111
private final JsonFactory FACTORY = JsonFactory.builder()
12-
.streamReadConfig(new StreamReadConfig().maxNumberLength(1000000))
12+
.streamReadConfig(new StreamReadConfig().withMaxNumberLength(1000000))
1313
.build();
1414

1515
// NOTE: this should be long enough to trigger perf problems

src/test/java/com/fasterxml/jackson/core/read/NumberParsingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@ public void testLongNumbers2() throws Exception
709709
}
710710
final String DOC = input.toString();
711711
JsonFactory f = JsonFactory.builder()
712-
.streamReadConfig(new StreamReadConfig().maxNumberLength(10000))
712+
.streamReadConfig(new StreamReadConfig().withMaxNumberLength(10000))
713713
.build();
714714
_testIssue160LongNumbers(f, DOC, false);
715715
_testIssue160LongNumbers(f, DOC, true);

0 commit comments

Comments
 (0)