Skip to content

Commit 78e28f4

Browse files
committed
- rebased
- added PR trigger - fixed unnecessary line in processor.py - changed testing file name to include coverage - removed update_requirements.yml
1 parent 5050752 commit 78e28f4

File tree

3 files changed

+5
-41
lines changed

3 files changed

+5
-41
lines changed

.github/workflows/testing.yml renamed to .github/workflows/testing_coverage.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
name: pytest
1+
name: pytest and coverage report
22

3-
# Triggers the workflow on push for all branches
4-
on: [push]
3+
# Triggers the workflow on push and PR for all branches
4+
on: [push, pull_request]
55

66
jobs:
77
pytest:
@@ -20,11 +20,12 @@ jobs:
2020
python-version: 3.8
2121
poetry-version: 1.2.2
2222

23-
# Run pytest with coverage report and upload results to coveralls
23+
# Run pytest with coverage report, saving to xml
2424
- name: Run tests on python 3.8
2525
run: |
2626
poetry run pytest --cov --cov-report xml:cobertura.xml --full-trace --show-capture=no -sv -n auto tests/
2727
28+
# Take report and upload to coveralls
2829
- name: Coveralls
2930
uses: coverallsapp/github-action@v2
3031
with:

.github/workflows/update_requirements.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

tests/test_processor.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,6 @@ def test_compute():
667667
metadata["user0"]["email"] = "email"
668668
# NXinstrument
669669
metadata["instrument"] = {}
670-
metadata["instrument"] = {}
671670
# analyzer
672671
metadata["instrument"]["analyzer"] = {}
673672
metadata["instrument"]["analyzer"]["energy_resolution"] = 110.0

0 commit comments

Comments
 (0)