Magic Number: Leading Zeros (#479)

* fixing magic number for leading zeros

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

Author: lucasborin

changelog.txt

@@ -18,6 +18,7 @@ Legend
 
 2021-08-XX v.1.16.0
 ------------------
+* Magic Number: Leading Zeros (#479)
 * Prefer New to Create Object: Dynamic Type (#469)
 * Magic Number: Table Index (#468)
 * Use native *_wa variables (#474)

src/checks/y_check_magic_number.clas.abap

@@ -72,9 +72,10 @@ CLASS y_check_magic_number IMPLEMENTATION.
   METHOD is_magic_number.
     DATA(string) = token_wa-str.
     REPLACE ALL OCCURRENCES OF |'| IN string WITH ||.
+
     result = xsdbool( string IS NOT INITIAL
                   AND string CO '0123456789'
-                  AND string <> '0'
+                  AND string CN '0'
                   AND string <> '1' ).
   ENDMETHOD.
 

src/checks/y_check_magic_number.clas.testclasses.abap

@@ -336,3 +336,23 @@ CLASS ltc_empty_string IMPLEMENTATION.
   ENDMETHOD.
 
 ENDCLASS.
+
+
+CLASS ltc_leading_zeros DEFINITION INHERITING FROM ltc_if FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
+  PROTECTED SECTION.
+    METHODS get_code_without_issue REDEFINITION.
+ENDCLASS.
+
+CLASS ltc_leading_zeros IMPLEMENTATION.
+
+  METHOD get_code_without_issue.
+    result = VALUE #(
+      ( ' REPORT ut_test.' )
+      ( ' START-OF-SELECTION.' )
+      ( |   DATA char TYPE c LENGTH 6. | )
+      ( |   IF char = '000000'. | )
+      ( '   ENDIF. ' )
+    ).
+  ENDMETHOD.
+
+ENDCLASS.