Looking for feedback on integrating CliWrap with Elsa Workflows #281
Unanswered
adamfisher
asked this question in
Q&A
Replies: 1 comment 1 reply
-
I left some comments but overall nothing really caught my eye 👍🏻 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I am currently working on a PR to integrate CliWrap into the open source Elsa Workflows project and I would appreciate a review of this pull request by anyone here that's interested if possible.
The main code of interest is
InvokeCommand
which is an activity that exposesInput<>
andOutput<>
properties to expose various options from CliWrap for invoking a single command line operation. I tried to leave the types of the inputs and outputs as flexible as possible and then detect the types at runtime to determine what type of pipe source or pipe target needed to be created. I expose the pipes on the activity so that the output from one activity can be fed into subsequent invocations of theInvokeCommand
activity.Beta Was this translation helpful? Give feedback.
All reactions