-
Notifications
You must be signed in to change notification settings - Fork 18
chore: Manually regenerate SDK #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have a generate failure because we've pulled `general.py` out for some custom changes. This will hit the occasional bump as new code is added to this file upstream. The steps for fixing this: - Remove `general.py` from .genignore - Run speakeasy generate - Stage and commit the autogenerated changes, working around our custom code - Commit without the `.genignore` change
@claude a review please |
Uh oh, looks like we need a bit more work to enable it over here - https://github.com/Unstructured-IO/unstructured-python-client/actions/runs/16507745390/job/46682622133 In any case since most of this is autogenerated it may not be very helpful. |
hmm yeah i thought i enabled this already - i will follow up when crag is back :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
message: str | ||
status_code: int | ||
body: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi we raise body back to plugins as httpexception(detail=e.body)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and i think the message here could be something like
"API error occurred: Status 402 Content-Type application/json. Body: {\"detail\": \"api key Not found etc\"}"
which is too long for the error msg back to user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would have preferred it if they didn't concatenate everything like that. At least body
will still be the actual json so we can pull out the server response.
We have a generate failure because we've pulled
general.py
out for some custom changes. (See #270) This will hit the occasional bump as new code is added to this file upstream. The steps for fixing this:general.py
from .genignore.genignore
changeI set
gen.yaml
to version 0.41.0. This will cause the next generate job to propagate the new version and publish it.