Merge pull request #1 from lezhumain/main

Fix call stack exceeded error and add balance checks in typescript

Author: ahtrahdis7

.github/workflows/npm.js.yml

@@ -0,0 +1,27 @@
+# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
+
+name: Node.js CI
+
+on: [pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [18.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+      - run: npm ci
+      - run: npm run build --if-present
+      - run: npm test

.gitignore

@@ -0,0 +1,3 @@
+test.js
+test_utils.js
+*.js.map

index.js

@@ -55,13 +55,15 @@ function simplifyDebts(transactions){
         let minMax = getMaxMinCredit();
         if(minMax[0] == undefined || minMax[1] == undefined) return;
         let min_value = Math.min(-transaction_map.get(minMax[0]), transaction_map.get(minMax[1]));
-  
-        transaction_map.set(minMax[0], transaction_map.get(minMax[0]) + min_value);
-        transaction_map.set(minMax[1], transaction_map.get(minMax[1]) - min_value);
-  
-        let res = [minMax[0], minMax[1], min_value];
-        splits.push(res);
-        helper();    
+
+        if(min_value !== 0) {
+            transaction_map.set(minMax[0], transaction_map.get(minMax[0]) + min_value);
+            transaction_map.set(minMax[1], transaction_map.get(minMax[1]) - min_value);
+
+            let res = [minMax[0], minMax[1], min_value];
+            splits.push(res);
+            helper();
+        }
     }
 
     settleSimilarFigures();

package-lock.json

@@ -1,32 +1,35 @@
 {
-    "name": "splitwise-js-map",
-    "version": "1.0.3",
-    "description": "Minimize Cash Flow among a given set of friends who have borrowed money from each other. Given a number of friends who have to give or take some amount of money from one another. Design an algorithm by which the total cash flow among all the friends is minimized.",
-    "main": "index.js",
-    "scripts": {
-      "test": "node test"
-    },
-    "repository": {
-      "type": "git",
-      "url": "git+https://github.com/ahtrahdis7/splitwise.git"
-    },
-    "dependencies": {
-    },
-    "keywords": [
-      "splitwise",
-      "javascript",
-      "algorithm",
-      "Javascript",
-      "split-wise",
-      "split-wize",
-      "splitwize",
-      "split"
-    ],
-    "author": "Sidhartha Mallick",
-    "license": "ISC",
-    "bugs": {
-      "url": "https://github.com/ahtrahdis7/splitwise/issues"
-    },
-    "homepage": "https://github.com/ahtrahdis7/splitwise#readme"
+  "name": "splitwise-js-map",
+  "version": "1.0.3",
+  "description": "Minimize Cash Flow among a given set of friends who have borrowed money from each other. Given a number of friends who have to give or take some amount of money from one another. Design an algorithm by which the total cash flow among all the friends is minimized.",
+  "main": "index.js",
+  "scripts": {
+    "build": "npx tsc",
+    "test": "npm run build && node test",
+    "test-ts": "npm run build && npx ts-node test.ts"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ahtrahdis7/node-splitwise-js.git"
+  },
+  "keywords": [
+    "splitwise",
+    "javascript",
+    "algorithm",
+    "Javascript",
+    "split-wise",
+    "split-wize",
+    "splitwize",
+    "split"
+  ],
+  "author": "Sidhartha Mallick",
+  "license": "ISC",
+  "bugs": {
+    "url": "https://github.com/ahtrahdis7/node-splitwise-js/issues"
+  },
+  "homepage": "https://github.com/ahtrahdis7/node-splitwise-js#readme",
+  "devDependencies": {
+    "ts-node": "^10.9.1",
+    "typescript": "^5.1.3"
   }
-  
+}

package.json

@@ -0,0 +1,42 @@
+import {checkBalance, SplitwiseInputItem} from "./test_utils";
+
+// @ts-ignore
+const Splitwise = require('./index');
+
+let splits;
+
+let input: SplitwiseInputItem[] = [
+    {
+      'paidBy': 'A',
+      'paidFor': { 'B': 300, 'C': 40, 'D': 30 }
+    },
+    {
+      'paidBy': 'B',
+      'paidFor': { 'A': 50, 'B': 100, 'C': 200 }
+    }
+];
+splits = Splitwise(input);
+checkBalance(splits, input);
+console.log(splits);
+
+
+input = [
+    {
+        "paidBy": "A",
+        "paidFor": {
+            "B": 14.26,
+            "C": 14.26,
+            "D": 14.26
+        }
+    },
+    {
+        "paidBy": "B",
+        "paidFor": {
+            "C": 7,
+            "D": 7
+        }
+    }
+];
+splits = Splitwise(input);
+checkBalance(splits, input);
+console.log(splits);