Skip to content

Support setting boolean config options to false #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Support setting boolean config options to false #6

merged 1 commit into from
Oct 28, 2016

Conversation

TuckerWhitehouse
Copy link
Contributor

Setting isShowIssues to false is not possible with the existing code, because any "falsy" value will be reverted to the default.

Setting isShowIssues to false is not possible with the existing code, because any "falsy" value will be reverted to the default.
@aleen42
Copy link
Owner

aleen42 commented Oct 28, 2016

Thanks for debugging. @TuckerWhitehouse

@aleen42 aleen42 merged commit 2c5cb3d into aleen42:master Oct 28, 2016
@TuckerWhitehouse TuckerWhitehouse deleted the patch-1 branch October 28, 2016 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants