More fixes, goal is code quality of 6

Author: beneschtech

picorpcserver/__init__.py

@@ -142,9 +142,9 @@ def run():
             continue
         method = jreq.method
         if method not in _GFUNCMAP:
-            jex = JsonRpcException(-32601,method,jreq.id)
+            jex = JsonRPCException(-32601,method,jreq.id)
             resp = JSONRPCResponse(jreq)
-            resp.fromException(je)
+            resp.fromException(jex)
             resp.send(hreq)
             continue
         try:
@@ -162,6 +162,6 @@ def run():
             print(f"Exception caught! {str(e)}")
             ex = JsonRPCSystemError(e)
             resp = JSONRPCResponse(jreq)
-            resp.fromException(je)
+            resp.fromException(ex)
             resp.send(hreq)
             continue

picorpcserver/httprequest.py

@@ -1,3 +1,10 @@
+"""
+Implements basic HTTP request parsing. This does not support SSL or anything like that
+but can be used to serve a simple web server if needed. The underlying process to jsonrpc
+It can verifiably stand on its own if needed.
+"""
+import socket
+from .netmgr import NetMgr
 class HTTPRequest:
 
     raw_msg = ""
@@ -11,6 +18,11 @@ class HTTPRequest:
     protocol = ""
 
     def __init__(self,nm,sock):
+        """
+        Initializes the http server, it requires the following parameters
+        nm: A connected NetMgr object
+        sock: A socket that is successfully listening
+        """
         self.hsock = sock
         self.nmgr = nm
         self.verbose = nm.verbose
@@ -20,15 +32,27 @@ def __init__(self,nm,sock):
         self._parse()
 
     def socket(self):
+        """
+        Returns the listening socket used to create this object
+        """
         return self.hsock
 
     def net_manager(self):
+        """
+        Returns the connected NetMgr object used to construct the object
+        """
         return self.nmgr
 
     def raw_message(self):
+        """
+        Returns the raw message read from the socket to process
+        """
         return self.raw_msg
 
     def _parse(self):
+        """
+        Parses the message filling in the method, url, headers, and raw message sent.
+        """
         if self.verbose:
             print("HTTPRequest::parse")
         try:
@@ -57,15 +81,33 @@ def _parse(self):
         return True
 
     def method(self):
+        """
+        The method used for this request, usually POST or GET
+        """
         return self.method
+
     def url(self):
+        """
+        The URL being requested
+        """
         return self.uri
+
     def protocol(self):
+        """
+        The request protocol, usually HTTP/1.1
+        """
         return self.protocol
+
     def payload(self):
+        """
+        The raw data sent after the headers. Will be blank if its a get request
+        """
         return self.payload
 
     def headerval(self,key):
+        """
+        Returns a case insensitive match for a header and retrieve its value
+        """
         if self.verbose:
             print(f"HTTPRequest::headerval ({key})")