Skip to content

Commit 69a6d52

Browse files
authored
fix embedding selection (#2543)
reverted code to previous implementation that was presumably changed due to a "destructuring assignment" lint error; explicitly ignoring error now
1 parent 06da05e commit 69a6d52

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

client/src/util/stateManager/viewStackHelpers.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,13 @@ function _getEmbeddingRowOffsets(baseRowIndex, embeddingDf) {
137137
- if the embedding contains NaN coordinates, return a rowIndex
138138
that contains only the rows with discrete valued coordinates.
139139
140-
Currently assumes that there will be onl two dimensions in the embedding.
140+
Currently assumes that there will be only two dimensions in the embedding.
141141
*/
142-
const { icol } = embeddingDf;
143-
const X = icol(0).asArray();
144-
const Y = icol(1).asArray();
142+
// eslint-disable-next-line react/destructuring-assignment -- destructuring fails
143+
const X = embeddingDf.icol(0).asArray();
144+
// eslint-disable-next-line react/destructuring-assignment -- destructuring fails
145+
const Y = embeddingDf.icol(1).asArray();
146+
145147
const offsets = new Int32Array(X.length);
146148
let numOffsets = 0;
147149

0 commit comments

Comments
 (0)