feat(core): Transaction.getFee

Author: Hanssen0

.changeset/new-flowers-accept.md

@@ -0,0 +1,5 @@
+---
+"@ckb-ccc/core": minor
+---
+
+feat(core): Transaction.getFee

packages/core/src/ckb/transaction.ts

@@ -1643,13 +1643,13 @@ export class Transaction extends mol.Entity.Base<
     return this.completeInputsAddOne(from, filter);
   }
 
-  async fee(client: Client): Promise<Num> {
+  async getFee(client: Client): Promise<Num> {
     return (await this.getInputsCapacity(client)) - this.getOutputsCapacity();
   }
 
-  async feeRate(client: Client): Promise<Num> {
+  async getFeeRate(client: Client): Promise<Num> {
     return (
-      ((await this.fee(client)) * numFrom(1000)) /
+      ((await this.getFee(client)) * numFrom(1000)) /
       numFrom(this.toBytes().length + 4)
     );
   }
@@ -1700,7 +1700,7 @@ export class Transaction extends mol.Entity.Base<
         // The initial fee is calculated based on prepared transaction
         leastFee = tx.estimateFee(feeRate);
       }
-      const fee = await tx.fee(from.client);
+      const fee = await tx.getFee(from.client);
       // The extra capacity paid the fee without a change
       if (fee === leastFee) {
         this.copy(tx);
@@ -1714,7 +1714,7 @@ export class Transaction extends mol.Entity.Base<
         continue;
       }
 
-      if ((await tx.fee(from.client)) !== leastFee) {
+      if ((await tx.getFee(from.client)) !== leastFee) {
         throw new Error(
           "The change function doesn't use all available capacity",
         );

packages/core/src/client/client.ts

@@ -596,9 +596,9 @@ export abstract class Client {
     const tx = Transaction.from(transaction);
 
     const maxFeeRate = numFrom(options?.maxFeeRate ?? DEFAULT_MAX_FEE_RATE);
-    const fee = await tx.feeRate(this);
-    if (maxFeeRate > Zero && fee > maxFeeRate) {
-      throw new ErrorClientMaxFeeRateExceeded(maxFeeRate, fee);
+    const feeRate = await tx.getFeeRate(this);
+    if (maxFeeRate > Zero && feeRate > maxFeeRate) {
+      throw new ErrorClientMaxFeeRateExceeded(maxFeeRate, feeRate);
     }
 
     const txHash = await this.sendTransactionNoCache(tx, validator);