chore: update electron sub dependencies (#27361)

* chore: update electron-context-menu to 3.6.1. electron-context-menu fixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted

* chore: update electron/get from v1 to v2. v2 drops node 12 so nothing breaking on our end

* chore: update electron-builder to ^v23.6.0 (checkTs passing)

* chore: upgrade electron packager to v16

* update electron-packager from v16 to v17

* run binary jobs for electron updates [run ci]

Author: AtofStryker

.circleci/workflows.yml

@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
         - /^release\/\d+\.\d+\.\d+$/
         # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
         - 'update-v8-snapshot-cache-on-develop'
-        - 'chore/debug-arm64-notary'
+        - 'chore/update-electron-sub-dependencies'
         - 'chore/use_cloud_m1_runners'
         - 'publish-binary'
 
@@ -43,7 +43,7 @@ macWorkflowFilters: &darwin-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'chore/debug-arm64-notary', << pipeline.git.branch >> ]
+    - equal: [ 'chore/update-electron-sub-dependencies', << pipeline.git.branch >> ]
     - equal: [ 'chore/use_cloud_m1_runners', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
@@ -55,7 +55,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'chore/debug-arm64-notary', << pipeline.git.branch >> ]
+    - equal: [ 'chore/update-electron-sub-dependencies', << pipeline.git.branch >> ]
     - equal: [ 'chore/use_cloud_m1_runners', << pipeline.git.branch >> ]
     - equal: [ 'publish-binary', << pipeline.git.branch >> ]
     - matches:
@@ -77,7 +77,7 @@ windowsWorkflowFilters: &windows-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'chore/debug-arm64-notary', << pipeline.git.branch >> ]
+    - equal: [ 'chore/update-electron-sub-dependencies', << pipeline.git.branch >> ]
     - equal: [ 'chore/use_cloud_m1_runners', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
@@ -148,7 +148,7 @@ commands:
           name: Set environment variable to determine whether or not to persist artifacts
           command: |
             echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
-            echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "publish-binary" && "$CIRCLE_BRANCH" != "mschile/issue-26900_browserCriClient" ]]; then
+            echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "publish-binary" && "$CIRCLE_BRANCH" != "chore/update-electron-sub-dependencies" ]]; then
                 export SHOULD_PERSIST_ARTIFACTS=true
             fi' >> "$BASH_ENV"
   # You must run `setup_should_persist_artifacts` command and be using bash before running this command

package.json

@@ -145,7 +145,7 @@
     "del": "3.0.0",
     "detect-port": "^1.3.0",
     "electron": "21.0.0",
-    "electron-builder": "^22.13.1",
+    "electron-builder": "^23.6.0",
     "enzyme-adapter-react-16": "1.12.1",
     "eslint": "7.22.0",
     "eslint-plugin-cypress": "2.11.2",

packages/electron/lib/install.js

@@ -133,7 +133,15 @@ module.exports = {
   },
 
   package (options = {}) {
-    const pkgr = require('electron-packager')
+    /**
+     * NOTE: electron-packager as of v16.0.0 does not play well with
+     * our mksnapshot. Requiring the package in this way, dynamically, will
+     * make it undiscoverable by mksnapshot, which is OK since electron-packager
+     * is a build dependency.
+     */
+    const e = 'electron'
+    const p = 'packager'
+    const pkgr = require(`${e}-${p}`)
     const icons = require('@packages/icons')
 
     const iconPath = icons.getPathToIcon('cypress')

packages/electron/package.json

@@ -24,7 +24,7 @@
     "minimist": "1.2.8"
   },
   "devDependencies": {
-    "electron-packager": "15.4.0",
+    "electron-packager": "17.0.0",
     "execa": "4.1.0",
     "mocha": "3.5.3",
     "systeminformation": "5.16.9"

packages/server/package.json

@@ -58,7 +58,7 @@
     "debug": "^4.3.4",
     "dirt-simple-file-cache": "^0.4.0",
     "duplexify": "4.1.1",
-    "electron-context-menu": "3.1.1",
+    "electron-context-menu": "3.6.1",
     "errorhandler": "1.5.1",
     "evil-dns": "0.2.0",
     "execa": "1.0.0",

patches/electron-context-menu+3.1.1.patch

@@ -17,7 +17,7 @@
     "watch": "tsc --watch"
   },
   "dependencies": {
-    "@electron/get": "^1.12.4",
+    "@electron/get": "^2.0.2",
     "debug": "^4.3.4",
     "extract-zip": "^2.0.1",
     "fs-extra": "^10.0.0",