Skip to content

Commit 9f02b8f

Browse files
Emantorjenswi-linaro
authored andcommitted
tee: optee: add might_sleep for RPC requests
If the kernel is compiled with CONFIG_PREEMPT_VOLUNTARY and OP-TEE is executing a long running workload, the following errors are raised: [ 1705.971228] rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [ 1705.977195] rcu: (detected by 0, t=2102 jiffies, g=51977, q=3) [ 1705.983152] rcu: All QSes seen, last rcu_sched kthread activity 2102 (140596-138494), jiffies_till_next_fqs=1, root ->qsmask 0x0 [ 1705.994729] optee-xtest R running task 0 169 157 0x00000002 While OP-TEE is returning regularly to the kernel due to timer interrupts, the OPTEE_SMC_FUNC_FOREIGN_INTR case does not contain an explicit rescheduling point. Add a might_sleep() to the RPC request case to ensure that the kernel can reschedule another task if OP-TEE requests RPC handling. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
1 parent 0ecfebd commit 9f02b8f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/tee/optee/call.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ u32 optee_do_call_with_arg(struct tee_context *ctx, phys_addr_t parg)
148148
*/
149149
optee_cq_wait_for_completion(&optee->call_queue, &w);
150150
} else if (OPTEE_SMC_RETURN_IS_RPC(res.a0)) {
151+
might_sleep();
151152
param.a0 = res.a0;
152153
param.a1 = res.a1;
153154
param.a2 = res.a2;

0 commit comments

Comments
 (0)