Skip to content

Commit b5469c5

Browse files
committed
Collection: fix replaceOne success return type UpdateResult<I> to allow custom defined _id types
1 parent bd026cf commit b5469c5

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.changeset/lovely-dots-lick.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect-mongodb": patch
3+
---
4+
5+
Fix `Collection.replaceOne` success return type `UpdateResult<I>` to allow custom defined `_id` types

packages/effect-mongodb/dtslint/Collection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ F.pipe(collection, Collection.updateMany({ birthday: "2024-11-28" }, { $set: { b
9191
// replaceOne
9292
// -------------------------------------------------------------------------------------
9393

94-
// $ExpectType Effect<Document | UpdateResult<Document>, MongoError | ParseError, never>
94+
// $ExpectType Effect<Document | UpdateResult<{ readonly birthday: string; }>, MongoError | ParseError, never>
9595
Collection.replaceOne(collection, { birthday: "2024-11-28" }, myType)
9696

97-
// $ExpectType Effect<Document | UpdateResult<Document>, MongoError | ParseError, never>
97+
// $ExpectType Effect<Document | UpdateResult<{ readonly birthday: string; }>, MongoError | ParseError, never>
9898
F.pipe(collection, Collection.replaceOne({ birthday: "2024-11-28" }, myType))
9999

100100
// -------------------------------------------------------------------------------------

packages/effect-mongodb/src/Collection.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,13 +221,13 @@ export const replaceOne: {
221221
options?: ReplaceOptions
222222
): <R>(
223223
collection: Collection<A, I, R>
224-
) => Effect.Effect<UpdateResult | Document, MongoError.MongoError | ParseResult.ParseError, R>
224+
) => Effect.Effect<UpdateResult<I> | Document, MongoError.MongoError | ParseResult.ParseError, R>
225225
<A extends Document, I extends Document, R>(
226226
collection: Collection<A, I, R>,
227227
filter: Filter<I>,
228228
replacement: A,
229229
options?: ReplaceOptions
230-
): Effect.Effect<UpdateResult | Document, MongoError.MongoError | ParseResult.ParseError, R>
230+
): Effect.Effect<UpdateResult<I> | Document, MongoError.MongoError | ParseResult.ParseError, R>
231231
} = F.dual(
232232
(args) => isCollection(args[0]),
233233
<A extends Document, I extends Document, R>(
@@ -236,7 +236,7 @@ export const replaceOne: {
236236
replacement: A,
237237
options?: ReplaceOptions
238238
): Effect.Effect<
239-
UpdateResult | Document,
239+
UpdateResult<I> | Document,
240240
MongoError.MongoError | ParseResult.ParseError,
241241
R
242242
> =>

0 commit comments

Comments
 (0)