Make CheckAllCommands error non-fatal

errordeveloper · errordeveloper · commit 99ff820c5b7e · 2018-06-05T14:55:33.000+01:00
diff --git a/cmd/eksctl/create.go b/cmd/eksctl/create.go
@@ -152,7 +152,8 @@ func doCreateCluster(cfg *eks.ClusterConfig) error {
 		// also check heptio-authenticator
 		// TODO: https://github.com/weaveworks/eksctl/issues/30
 		if err := utils.CheckAllCommands(kubeconfigPath); err != nil {
-			return err
+			logger.Critical(err.Error())
+			logger.Info("cluster should be functions despite missing client binaries that need to be installed in the PATH")
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,8 @@ func doCreateCluster(cfg *eks.ClusterConfig) error {`
`152`	`152`	`// also check heptio-authenticator`
`153`	`153`	`// TODO: https://github.com/weaveworks/eksctl/issues/30`
`154`	`154`	`if err := utils.CheckAllCommands(kubeconfigPath); err != nil {`
`155`		`- return err`
	`155`	`+ logger.Critical(err.Error())`
	`156`	`+ logger.Info("cluster should be functions despite missing client binaries that need to be installed in the PATH")`
`156`	`157`	`}`
`157`	`158`	`}`
`158`	`159`