Skip to content

Commit 46acb01

Browse files
committed
Address review comments
1 parent a92ab89 commit 46acb01

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

x-pack/metricbeat/module/oracle/connection.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func HostParser(mod mb.Module, rawURL string) (mb.HostData, error) {
4242
}
4343

4444
if params.Password.Secret() == "" {
45-
params.StandaloneConnection = true
45+
params.StandaloneConnection = godror.Bool(true)
4646
params.Password = dsn.NewPassword(config.Password)
4747
}
4848

x-pack/metricbeat/module/oracle/testing.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@ import (
1515
func GetOracleConnectionDetails(host string) string {
1616
params := godror.ConnectionParams{
1717
CommonParams: dsn.CommonParams{
18-
Username: GetOracleEnvUsername(),
19-
Password: dsn.NewPassword((GetOracleEnvPassword())),
18+
CommonSimpleParams: dsn.CommonSimpleParams{
19+
Username: GetOracleEnvUsername(),
20+
Password: dsn.NewPassword((GetOracleEnvPassword())),
21+
},
2022
},
2123
ConnParams: dsn.ConnParams{
22-
IsSysDBA: true,
24+
AdminRole: dsn.SysDBA,
2325
},
2426
}
2527

0 commit comments

Comments
 (0)