change golang to 1.23.10 (#44901)

pkoutsovasilis · pchila · web-flow · commit bb9ad7633fb9 · 2025-06-18T18:13:39.000+02:00
* Revert "[Automation][7.17] Bump Golang version to 1.24.4 (#43984)" This reverts commit 1c95a97. * fix: external process for watch_windows.go * bump golang to 1.23.10 * Update CHANGELOG.next.asciidoc Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> --------- Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
diff --git a/.go-version b/.go-version
@@ -1 +1 @@
-1.24.4
+1.23.10
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -108,7 +108,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 
 *Affecting all Beats*
 
-- Update to Go 1.24.4. {pull}43984[43984]
+- Update to Go 1.23.10. {pull}44901[44901]
 
 *Auditbeat*
 
diff --git a/auditbeat/Dockerfile b/auditbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/dev-tools/kubernetes/filebeat/Dockerfile.debug b/dev-tools/kubernetes/filebeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.24.4 as builder
+FROM golang:1.23.10 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/dev-tools/kubernetes/heartbeat/Dockerfile.debug b/dev-tools/kubernetes/heartbeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.24.4 as builder
+FROM golang:1.23.10 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/dev-tools/kubernetes/metricbeat/Dockerfile.debug b/dev-tools/kubernetes/metricbeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.24.4 as builder
+FROM golang:1.23.10 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/filebeat/Dockerfile b/filebeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/elastic/beats/v7
 
-go 1.24.4
+go 1.23.10
 
 require (
 	cloud.google.com/go/bigquery v1.59.1
diff --git a/heartbeat/Dockerfile b/heartbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/libbeat/Dockerfile b/libbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/libbeat/api/routes.go b/libbeat/api/routes.go
@@ -83,9 +83,9 @@ func makeAPIHandler(ns *monitoring.Namespace) handlerFunc {
 func prettyPrint(w http.ResponseWriter, data common.MapStr, u *url.URL) {
 	query := u.Query()
 	if _, ok := query["pretty"]; ok {
-		fmt.Fprint(w, data.StringToPrint())
+		fmt.Fprintf(w, data.StringToPrint())
 	} else {
-		fmt.Fprint(w, data.String())
+		fmt.Fprintf(w, data.String())
 	}
 }
 
diff --git a/libbeat/docs/version.asciidoc b/libbeat/docs/version.asciidoc
@@ -1,6 +1,6 @@
 :stack-version: 7.17.28
 :doc-branch: 7.17
-:go-version: 1.24.4
+:go-version: 1.23.10
 :release-state: unreleased
 :python: 3.7
 :docker: 1.12
diff --git a/libbeat/keystore/file_keystore_test.go b/libbeat/keystore/file_keystore_test.go
@@ -18,7 +18,6 @@
 package keystore
 
 import (
-	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -192,7 +191,7 @@ func TestCannotDecryptKeyStoreWithWrongPassword(t *testing.T) {
 	if assert.Error(t, err, "should fail to decrypt the keystore") {
 		m := `could not decrypt the keystore: could not decrypt keystore data: ` +
 			`cipher: message authentication failed`
-		assert.Equal(t, err, errors.New(m))
+		assert.Equal(t, err, fmt.Errorf(m))
 	}
 }
 
diff --git a/libbeat/kibana/client.go b/libbeat/kibana/client.go
@@ -22,7 +22,6 @@ import (
 	"context"
 	"encoding/base64"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"io/ioutil"
@@ -383,7 +382,7 @@ func (client *Client) Close() error { return nil }
 // GetDashboard returns the dashboard with the given id with the index pattern removed
 func (client *Client) GetDashboard(id string) ([]byte, error) {
 	if client.Version.LessThan(MinimumRequiredVersionSavedObjects) {
-		return nil, errors.New("Kibana version must be at least " + MinimumRequiredVersionSavedObjects.String())
+		return nil, fmt.Errorf("Kibana version must be at least " + MinimumRequiredVersionSavedObjects.String())
 	}
 
 	body := fmt.Sprintf(`{"objects": [{"type": "dashboard", "id": "%s" }], "includeReferencesDeep": true, "excludeExportDetails": true}`, id)
diff --git a/libbeat/ml-importer/importer.go b/libbeat/ml-importer/importer.go
@@ -243,7 +243,7 @@ func checkResponse(r []byte) error {
 				logp.Debug("machine-learning", "Datafeed already exists: %s, error: %s", feed.ID, feed.Error.Msg)
 				continue
 			}
-			errs = append(errs, errors.New(feed.Error.Msg))
+			errs = append(errs, errors.Errorf(feed.Error.Msg))
 		}
 	}
 	for _, job := range resp.Jobs {
@@ -252,7 +252,7 @@ func checkResponse(r []byte) error {
 			continue
 		}
 		if !job.Success {
-			errs = append(errs, errors.New(job.Error.Msg))
+			errs = append(errs, errors.Errorf(job.Error.Msg))
 		}
 	}
 	for _, dashboard := range resp.Kibana.Dashboard {
diff --git a/libbeat/processors/actions/replace.go b/libbeat/processors/actions/replace.go
@@ -83,7 +83,7 @@ func (f *replaceString) Run(event *beat.Event) (*beat.Event, error) {
 		err := f.replaceField(field.Field, field.Pattern, field.Replacement, event.Fields)
 		if err != nil {
 			errMsg := fmt.Errorf("Failed to replace fields in processor: %s", err)
-			logp.Debug("replace", "%s", errMsg.Error())
+			logp.Debug("replace", errMsg.Error())
 			if f.config.FailOnError {
 				event.Fields = backup
 				event.PutValue("error.message", errMsg.Error())
diff --git a/libbeat/processors/convert/convert.go b/libbeat/processors/convert/convert.go
@@ -372,7 +372,7 @@ func newConvertError(conversion field, cause error, tag string, message string,
 	}
 	buf.WriteString(" failed: ")
 	fmt.Fprintf(&buf, message, params...)
-	return errors.Wrap(cause, buf.String())
+	return errors.Wrapf(cause, buf.String())
 }
 
 // cloneValue returns a shallow copy of a map. All other types are passed
diff --git a/metricbeat/Dockerfile b/metricbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 COPY --from=docker:26.0.0-alpine3.19 /usr/local/bin/docker  /usr/local/bin/
 
 RUN \
diff --git a/metricbeat/module/http/_meta/Dockerfile b/metricbeat/module/http/_meta/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 COPY test/main.go main.go
 
diff --git a/metricbeat/module/nats/_meta/Dockerfile b/metricbeat/module/nats/_meta/Dockerfile
@@ -2,7 +2,7 @@ ARG NATS_VERSION=2.0.4
 FROM nats:$NATS_VERSION
 
 # build stage
-FROM golang:1.24.4 AS build-env
+FROM golang:1.23.10 AS build-env
 RUN apt-get install git mercurial gcc
 RUN git clone https://github.com/nats-io/nats.go.git /nats-go
 RUN cd /nats-go/examples/nats-bench && git checkout tags/v1.10.0 && go build .
diff --git a/metricbeat/module/vsphere/_meta/Dockerfile b/metricbeat/module/vsphere/_meta/Dockerfile
@@ -1,5 +1,5 @@
 ARG VSPHERE_GOLANG_VERSION
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN apt-get install curl git
 RUN go install github.com/vmware/govmomi/vcsim@v0.30.4
diff --git a/packetbeat/Dockerfile b/packetbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/x-pack/elastic-agent/pkg/agent/control/client/client.go b/x-pack/elastic-agent/pkg/agent/control/client/client.go
@@ -7,7 +7,8 @@ package client
 import (
 	"context"
 	"encoding/json"
-	"errors"
+	"fmt"
+
 	"sync"
 	"time"
 
@@ -185,7 +186,7 @@ func (c *client) Restart(ctx context.Context) error {
 		return err
 	}
 	if res.Status == cproto.ActionStatus_FAILURE {
-		return errors.New(res.Error)
+		return fmt.Errorf(res.Error)
 	}
 	return nil
 }
@@ -202,7 +203,7 @@ func (c *client) Upgrade(ctx context.Context, version string, sourceURI string,
 		return "", err
 	}
 	if res.Status == cproto.ActionStatus_FAILURE {
-		return "", errors.New(res.Error)
+		return "", fmt.Errorf(res.Error)
 	}
 	return res.Version, nil
 }
diff --git a/x-pack/elastic-agent/pkg/core/monitoring/server/handler.go b/x-pack/elastic-agent/pkg/core/monitoring/server/handler.go
@@ -35,10 +35,7 @@ func (h *apiHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 		}
 
-		writeResponse(w, errResponse{
-			Type:   errTypeUnexpected,
-			Reason: err.Error(),
-		})
+		writeResponse(w, unexpectedErrorWithReason(err.Error()))
 	}
 }
 
diff --git a/x-pack/elastic-agent/pkg/core/plugin/process/watch_windows.go b/x-pack/elastic-agent/pkg/core/plugin/process/watch_windows.go
@@ -11,6 +11,8 @@ import (
 	"os"
 	"syscall"
 	"time"
+
+	"golang.org/x/sys/windows"
 )
 
 const (
@@ -36,16 +38,17 @@ func (a *Application) externalProcess(proc *os.Process) {
 
 func isWindowsProcessExited(pid int) bool {
 	const desiredAccess = syscall.STANDARD_RIGHTS_READ | syscall.PROCESS_QUERY_INFORMATION | syscall.SYNCHRONIZE
-	h, err := syscall.OpenProcess(desiredAccess, false, uint32(pid))
+	h, err := windows.OpenProcess(desiredAccess, false, uint32(pid)) //nolint:gosec // G115 Conversion from int to uint32 is safe here.
 	if err != nil {
 		// failed to open handle, report exited
 		return true
 	}
+	defer windows.CloseHandle(h) //nolint:errcheck // No way to handle errors returned here so safe to ignore.
 
 	// get exit code, this returns immediately in case it is still running
 	// it returns exitCodeStillActive
 	var ec uint32
-	if err := syscall.GetExitCodeProcess(h, &ec); err != nil {
+	if err := windows.GetExitCodeProcess(h, &ec); err != nil {
 		// failed to contact, report exited
 		return true
 	}
diff --git a/x-pack/elastic-agent/pkg/reporter/reporter.go b/x-pack/elastic-agent/pkg/reporter/reporter.go
@@ -136,7 +136,7 @@ func generateRecord(agentID string, id string, name string, s state.State) event
 	}
 
 	err := errors.New(
-		errors.New(s.Message),
+		fmt.Errorf(s.Message),
 		fmt.Sprintf("Application: %s[%s]: State changed to %s", id, agentID, subTypeText),
 		errors.TypeApplication,
 		errors.M(errors.MetaKeyAppID, id),
diff --git a/x-pack/filebeat/input/awss3/input.go b/x-pack/filebeat/input/awss3/input.go
@@ -6,7 +6,6 @@ package awss3
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"net/url"
 	"strings"
@@ -252,15 +251,15 @@ func getRegionFromQueueURL(queueURL string, endpoint string) (string, error) {
 	// Example: https://sqs.us-east-1.amazonaws.com/627959692251/test-s3-logs
 	url, err := url.Parse(queueURL)
 	if err != nil {
-		return "", errors.New(queueURL + " is not a valid URL")
+		return "", fmt.Errorf(queueURL + " is not a valid URL")
 	}
 	if url.Scheme == "https" && url.Host != "" {
 		queueHostSplit := strings.Split(url.Host, ".")
 		if len(queueHostSplit) > 2 && (strings.Join(queueHostSplit[2:], ".") == endpoint || (endpoint == "" && queueHostSplit[2] == "amazonaws")) {
 			return queueHostSplit[1], nil
 		}
 	}
-	return "", errors.New("QueueURL is not in format: https://sqs.{REGION_ENDPOINT}.{ENDPOINT}/{ACCOUNT_NUMBER}/{QUEUE_NAME}")
+	return "", fmt.Errorf("QueueURL is not in format: https://sqs.{REGION_ENDPOINT}.{ENDPOINT}/{ACCOUNT_NUMBER}/{QUEUE_NAME}")
 }
 
 func getRegionForBucketARN(ctx context.Context, s3Client *s3.Client, bucketARN string) (string, error) {
diff --git a/x-pack/functionbeat/Dockerfile b/x-pack/functionbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/x-pack/libbeat/Dockerfile b/x-pack/libbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.24.4
+FROM golang:1.23.10
 
 RUN \
     apt-get update \
diff --git a/x-pack/metricbeat/module/stan/_meta/Dockerfile b/x-pack/metricbeat/module/stan/_meta/Dockerfile
@@ -2,7 +2,7 @@ ARG STAN_VERSION=0.15.1
 FROM nats-streaming:$STAN_VERSION
 
 # build stage
-FROM golang:1.24.4 AS build-env
+FROM golang:1.23.10 AS build-env
 RUN apt-get install git mercurial gcc
 RUN git clone https://github.com/nats-io/stan.go.git /stan-go
 RUN cd /stan-go/examples/stan-bench && git checkout tags/v0.5.2 && go build .

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.24.4`
	`1`	`+FROM golang:1.23.10`
`2`	`2`
`3`	`3`	`RUN \`
`4`	`4`	`apt-get update \`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.24.4 as builder`
	`1`	`+FROM golang:1.23.10 as builder`
`2`	`2`
`3`	`3`	`ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin`
`4`	`4`