Do not create kibana client for pipeline and static tests (#1567)

This PR avoids creating the kibana client for the tests where it is not
needed the access to Kibana (API). In this case, this is removed from
pipeline and static tests.

Author: mrodm

cmd/testrunner.go

@@ -16,6 +16,7 @@ import (
 	"github.com/elastic/elastic-package/internal/cobraext"
 	"github.com/elastic/elastic-package/internal/common"
 	"github.com/elastic/elastic-package/internal/install"
+	"github.com/elastic/elastic-package/internal/kibana"
 	"github.com/elastic/elastic-package/internal/packages"
 	"github.com/elastic/elastic-package/internal/signal"
 	"github.com/elastic/elastic-package/internal/stack"
@@ -224,9 +225,13 @@ func testTypeCommandActionFactory(runner testrunner.TestRunner) cobraext.Command
 			return err
 		}
 
-		kibanaClient, err := stack.NewKibanaClientFromProfile(profile)
-		if err != nil {
-			return fmt.Errorf("can't create Kibana client: %w", err)
+		var kibanaClient *kibana.Client
+		if testType == "system" || testType == "asset" {
+			// pipeline and static tests do not require a kibana client to perform their required operations
+			kibanaClient, err = stack.NewKibanaClientFromProfile(profile)
+			if err != nil {
+				return fmt.Errorf("can't create Kibana client: %w", err)
+			}
 		}
 
 		var results []testrunner.TestResult

internal/testrunner/runners/asset/runner.go

@@ -5,6 +5,7 @@
 package asset
 
 import (
+	"errors"
 	"fmt"
 	"strings"
 
@@ -64,6 +65,10 @@ func (r *runner) run() ([]testrunner.TestResult, error) {
 		Package:  r.testFolder.Package,
 	})
 
+	if r.kibanaClient == nil {
+		return result.WithError(errors.New("missing Kibana client"))
+	}
+
 	testConfig, err := newConfig(r.testFolder.Path)
 	if err != nil {
 		return result.WithError(fmt.Errorf("unable to load asset loading test config file: %w", err))

internal/testrunner/runners/pipeline/runner.go

@@ -112,6 +112,10 @@ func (r *runner) run() ([]testrunner.TestResult, error) {
 		return nil, fmt.Errorf("listing test case definitions failed: %w", err)
 	}
 
+	if r.options.API == nil {
+		return nil, errors.New("missing Elasticsearch client")
+	}
+
 	dataStreamPath, found, err := packages.FindDataStreamRootForPath(r.options.TestFolder.Path)
 	if err != nil {
 		return nil, fmt.Errorf("locating data_stream root failed: %w", err)

internal/testrunner/runners/system/runner.go

@@ -210,6 +210,13 @@ func (r *runner) run() (results []testrunner.TestResult, err error) {
 		logger.Debug("Running system tests for package")
 	}
 
+	if r.options.API == nil {
+		return result.WithError(errors.New("missing Elasticsearch client"))
+	}
+	if r.options.KibanaClient == nil {
+		return result.WithError(errors.New("missing Kibana client"))
+	}
+
 	stackVersion, err := r.options.KibanaClient.Version()
 	if err != nil {
 		return result.WithError(fmt.Errorf("cannot request Kibana version: %w", err))