Fix validation of number types

Author: mrodm

internal/fields/mappings.go

@@ -11,6 +11,7 @@ import (
 	"fmt"
 	"path/filepath"
 	"slices"
+	"strings"
 
 	"github.com/Masterminds/semver/v3"
 	"github.com/google/go-cmp/cmp"
@@ -687,10 +688,13 @@ func (v *MappingValidator) validateObjectMappingAndParameters(previewValue, actu
 			return errs
 		}
 
+		// Strings from `json.Marshal` include double quotes, so they need to be removed (e.g. "\"float\"")
+		previewDataString := strings.ReplaceAll(string(previewData), "\"", "")
+		actualDataString := strings.ReplaceAll(string(actualData), "\"", "")
 		// exceptions related to numbers
 		// https://github.com/elastic/elastic-package/blob/8cc126ae5015dd336b22901c365e8c98db4e7c15/internal/fields/validate.go#L1234-L1247
-		if isNumberTypeField(string(previewData), string(actualData)) {
-			logger.Debugf("Allowed number fields with different types (preview %s - actual %s)", string(previewData), string(actualData))
+		if isNumberTypeField(previewDataString, actualDataString) {
+			logger.Debugf("Allowed number fields with different types (preview %s - actual %s)", previewDataString, actualDataString)
 			return nil
 		}
 

internal/fields/mappings_test.go

@@ -569,6 +569,30 @@ func TestComparingMappings(t *testing.T) {
 				`unexpected value found in mapping for field "foo.type.ignore_above": preview mappings value (1024) different from the actual mappings value (2048)`,
 			},
 		},
+		{
+			title: "different number types",
+			preview: map[string]any{
+				"foo": map[string]any{
+					"type": "float",
+				},
+			},
+			actual: map[string]any{
+				"foo": map[string]any{
+					"type": "long",
+				},
+				"bar": map[string]any{
+					"type": "long",
+				},
+			},
+			schema: []FieldDefinition{
+				{
+					Name:     "bar",
+					Type:     "float",
+					External: "ecs",
+				},
+			},
+			expectedErrors: []string{},
+		},
 	}
 
 	for _, c := range cases {