-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Observability] Add observability rules priviliges feature !! #227582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR more appropriately lays the groundwork for the universal ability to manage alerts and rules in an app/plugin without having to create a subfeature in each one. The only gap I can identify after working on this issue is the ability to manage alert default settings in synthetics. |
@shahzad31 Could you please update the description with all assumptions? What is the expected behavior of the new feature privilege? What is the expected behavior of the rest of the o11y feature privileges regarding rules and alerts? How does the PR avoid breaking changes? How will this new feature privilege work on serverless? It will help a lot with the review. |
Can we also turn this one into a Draft until CI is green? 🙏 Just to help manage the review queue more effectively. |
/ci |
/ci |
/ci |
/ci |
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
api: ['rac'], | ||
savedObject: { | ||
all: [], | ||
read: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to give this feature permission to read all saved objects types being read in rules, examples being synthetics monitors, slo saved objects, infra sources configuration and potentially apm settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to give this feature permission to read all saved objects types being read in rules, examples being synthetics monitors, slo saved objects, infra sources configuration and potentially apm settings
I wasn't anticipating this, but I see why you mention it. I was picturing this was only to grant the rule permissions, and any additional permissions for the apps would need to be provided by way of the app permissions. But yeah, all these rules will be weirdly broken if we don't provide this access. But then do the APM rules use the APM Kibana REST APIs for their queries? If so, we need to provide that read access in this rule, too? Does the Burn Rate rule use SLO APIs?
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8907[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 0/1 tests passed. |
b83175f
to
9f0d7c1
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
Summary
Closes https://github.com/elastic/observability-dev/issues/4683 !!
Enabling this feature will grant user access to all observability rules and alerts.
Observability
is added as a consumer and an option for role visibility. Any user with read permissions to the new rules privilege will be able to see rules created for any observability feature, including logs and metrics/infrastructure.Users who are given read/write access to the new rules feature, but no access to other observability features, may have issues creating rules as they may not be able to view data.
This PR DOES NOT change any ui permissions settings for existing plugins with respect to alerting. Users who only have the "Observability Rules and Alerts" privilege will not be able to manage alerts from the respective plugin header menus if the existing capabilities check for write permissions for that plugin.
Testing
Existing users should be able to access alerts and rules as is.
Plugin consumed rules:
Generic rules: