Revert "internal: temporarily disable tests so we can land CL 410955"

Robert Griesemer · Robert Griesemer · commit 6bfd3a440e1b · 2022-06-08T01:09:07.000Z
This reverts commit 5ca4cc8. Reason for revert: appears insufficient to land CL 410955. Change-Id: If7029c9a43568e210e89d473b738400f5155715e Reviewed-on: https://go-review.googlesource.com/c/tools/+/410995 Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Robert Findley <rfindley@google.com> Run-TryBot: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> gopls-CI: kokoro <noreply+kokoro@google.com>
diff --git a/internal/lsp/tests/tests.go b/internal/lsp/tests/tests.go
@@ -544,8 +544,6 @@ func moveFile(oldpath, newpath string) (err error) {
 }
 
 func Run(t *testing.T, tests Tests, data *Data) {
-	t.Skip() // re-enable once CL 410955 has landed
-
 	t.Helper()
 	checkData(t, data)
 
diff --git a/internal/typeparams/normalize_test.go b/internal/typeparams/normalize_test.go
@@ -17,8 +17,6 @@ import (
 )
 
 func TestStructuralTerms(t *testing.T) {
-	t.Skip() // re-enable once CL 410955 has landed
-
 	if !Enabled {
 		t.Skip("typeparams are not enabled")
 	}

Original file line number	Diff line number	Diff line change
`@@ -544,8 +544,6 @@ func moveFile(oldpath, newpath string) (err error) {`
`544`	`544`	`}`
`545`	`545`
`546`	`546`	`func Run(t testing.T, tests Tests, data Data) {`
`547`		`- t.Skip() // re-enable once CL 410955 has landed`
`548`		`-`
`549`	`547`	`t.Helper()`
`550`	`548`	`checkData(t, data)`
`551`	`549`
Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ import (`
`17`	`17`	`)`
`18`	`18`
`19`	`19`	`func TestStructuralTerms(t *testing.T) {`
`20`		`- t.Skip() // re-enable once CL 410955 has landed`
`21`		`-`
`22`	`20`	`if !Enabled {`
`23`	`21`	`t.Skip("typeparams are not enabled")`
`24`	`22`	`}`