Skip to content

Commit 1f468b3

Browse files
author
Pavel V Chupin
committed
Replace OPENCL_ICD_LOADER_HEADERS_DIR with OpenCL_INCLUDE_DIR
Also cleanup in a few places where it's not used
1 parent 26dd1b1 commit 1f468b3

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

opencl/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ FetchContent_Declare(ocl-headers
1212

1313
FetchContent_MakeAvailable(ocl-headers)
1414
FetchContent_GetProperties(ocl-headers)
15-
set(OpenCL_INCLUDE_DIRS ${ocl-headers_SOURCE_DIR})
15+
set(OpenCL_INCLUDE_DIR
16+
${ocl-headers_SOURCE_DIR} CACHE PATH "Path to OpenCL Headers")
1617

1718
target_compile_definitions(Headers INTERFACE -DCL_TARGET_OPENCL_VERSION=220)
1819
add_library(OpenCL-Headers ALIAS Headers)
@@ -21,7 +22,7 @@ add_library(OpenCL-Headers ALIAS Headers)
2122

2223
# Set OPENCL_ICD_LOADER_HEADERS_DIR, as prerequisite for ICD build
2324
set(OPENCL_ICD_LOADER_HEADERS_DIR
24-
${OpenCL_INCLUDE_DIRS} PATH "Path to OpenCL Headers")
25+
${OpenCL_INCLUDE_DIR} CACHE PATH "Path to OpenCL Headers")
2526

2627
# LLVM build sets this OFF by default, but we need OpenCL to be built as shared
2728
# library.

sycl/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ endif()
8080
# Copy OpenCL Headers into sycl headers build directory
8181
# Compiler does automatic lookup bin/../include based on clang binary location,
8282
# e.g. when run LIT tests
83-
file(COPY ${OPENCL_ICD_LOADER_HEADERS_DIR}/CL
83+
file(COPY ${OpenCL_INCLUDE_DIR}/CL
8484
DESTINATION ${SYCL_INCLUDE_BUILD_DIR}/sycl)
8585

8686
# Include OpenCL Headers into final bundle.
87-
install(DIRECTORY ${OPENCL_ICD_LOADER_HEADERS_DIR}/CL
87+
install(DIRECTORY ${OpenCL_INCLUDE_DIR}/CL
8888
DESTINATION ${SYCL_INCLUDE_DEPLOY_DIR}/sycl
8989
COMPONENT OpenCL-Headers)
9090

sycl/plugins/level_zero/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ if (NOT DEFINED LEVEL_ZERO_LIBRARY OR NOT DEFINED LEVEL_ZERO_INCLUDE_DIR)
3939
INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/level_zero_loader_install"
4040
CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
4141
-DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
42-
-DOpenCL_INCLUDE_DIR=${OpenCL_INCLUDE_DIRS}
4342
-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>
4443
-DCMAKE_INSTALL_LIBDIR:PATH=lib${LLVM_LIBDIR_SUFFIX}
4544
${AUX_CMAKE_FLAGS}

sycl/tools/sycl-ls/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
add_executable(sycl-ls sycl-ls.cpp)
22
add_dependencies(sycl-ls sycl)
3-
target_include_directories(sycl-ls PRIVATE "${sycl_inc_dir}"
4-
#FIXME: OpenCL headers has to be added explicitly here for CUDA target build,
5-
# to overrule OpenCL headers included in CUDA which are implicitly present
6-
# as sycl target interface (for CUDA build)
7-
# This shouldn't be required if sycl-ls app would depend solely on SYCL
8-
# headers, but currently it requires OpenCL headers
9-
"${OPENCL_ICD_LOADER_HEADERS_DIR}")
3+
target_include_directories(sycl-ls PRIVATE "${sycl_inc_dir}")
104
target_link_libraries(sycl-ls
115
PRIVATE
126
sycl

0 commit comments

Comments
 (0)