Skip to content

Commit 17e63e8

Browse files
Daniel Ballarerobika
authored andcommitted
Fix overflow in ecma_op_dataview_create (#3111)
Fixes #3109 JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu
1 parent 9f85d21 commit 17e63e8

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

jerry-core/ecma/operations/ecma-dataview-object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ ecma_op_dataview_create (const ecma_value_t *arguments_list_p, /**< arguments li
135135
}
136136

137137
/* 12.c */
138-
if ((ecma_length_t) offset + viewByteLength > buffer_byte_length)
138+
if ((ecma_number_t) offset + viewByteLength > buffer_byte_length)
139139
{
140140
return ecma_raise_range_error (ECMA_ERR_MSG ("Start offset is outside the bounds of the buffer."));
141141
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Copyright JS Foundation and other contributors, http://js.foundation
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
var arrb = new ArrayBuffer(14);
16+
17+
try {
18+
var arr = new DataView(arrb, 13, Infinity);
19+
assert(false);
20+
arr.setUint32(9, -65536);
21+
} catch (e) {
22+
assert(e instanceof RangeError);
23+
}

0 commit comments

Comments
 (0)