From a8942cd8d135194388cb9aadb8fbaf4bee073cc2 Mon Sep 17 00:00:00 2001 From: kemuru <102478601+kemuru@users.noreply.github.com> Date: Sat, 9 Aug 2025 22:10:47 +0200 Subject: [PATCH 1/2] fix: add shutter api check --- web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx b/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx index db7172f74..437bfb3c2 100644 --- a/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx +++ b/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx @@ -85,6 +85,10 @@ const Commit: React.FC = ({ const handleCommit = useCallback( async (choice: bigint) => { + if (!import.meta.env.REACT_APP_SHUTTER_API) { + console.error("REACT_APP_SHUTTER_API environment variable is not set"); + throw new Error("Cannot commit vote: REACT_APP_SHUTTER_API environment variable is required but not set"); + } const message = { message: saltKey }; const rawSalt = !isUndefined(signingAccount) ? await signingAccount.signMessage(message) From 89848eaddcd22b8d3a9ac2d66f95ac2613ba9b1b Mon Sep 17 00:00:00 2001 From: kemuru <102478601+kemuru@users.noreply.github.com> Date: Sat, 9 Aug 2025 22:14:15 +0200 Subject: [PATCH 2/2] chore: check that its not empty too just in case --- web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx b/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx index 437bfb3c2..28363514f 100644 --- a/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx +++ b/web/src/pages/Cases/CaseDetails/Voting/Shutter/Commit.tsx @@ -85,8 +85,8 @@ const Commit: React.FC = ({ const handleCommit = useCallback( async (choice: bigint) => { - if (!import.meta.env.REACT_APP_SHUTTER_API) { - console.error("REACT_APP_SHUTTER_API environment variable is not set"); + if (!import.meta.env.REACT_APP_SHUTTER_API || import.meta.env.REACT_APP_SHUTTER_API.trim() === "") { + console.error("REACT_APP_SHUTTER_API environment variable is not set or is empty"); throw new Error("Cannot commit vote: REACT_APP_SHUTTER_API environment variable is required but not set"); } const message = { message: saltKey };