Only check immediate value for v_mov_b32

arsenm · arsenm · commit 547f00073c11 · 2025-07-18T16:30:01.000+09:00
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUPrepareAGPRAlloc.cpp b/llvm/lib/Target/AMDGPU/AMDGPUPrepareAGPRAlloc.cpp
@@ -94,12 +94,12 @@ bool AMDGPUPrepareAGPRAllocImpl::run(MachineFunction &MF) {
   bool Changed = false;
   for (MachineBasicBlock &MBB : MF) {
     for (MachineInstr &MI : MBB) {
-      if (MI.getOpcode() == AMDGPU::V_MOV_B32_e32 ||
-          MI.getOpcode() == AMDGPU::V_ACCVGPR_WRITE_B32_e64) {
-        if (TII.isInlineConstant(MI, 1)) {
-          MI.setDesc(AVImmPseudo);
-          Changed = true;
-        }
+      if ((MI.getOpcode() == AMDGPU::V_MOV_B32_e32 &&
+           TII.isInlineConstant(MI, 1)) ||
+          (MI.getOpcode() == AMDGPU::V_ACCVGPR_WRITE_B32_e64 &&
+           MI.getOperand(1).isImm())) {
+        MI.setDesc(AVImmPseudo);
+        Changed = true;
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -94,12 +94,12 @@ bool AMDGPUPrepareAGPRAllocImpl::run(MachineFunction &MF) {`
`94`	`94`	`bool Changed = false;`
`95`	`95`	`for (MachineBasicBlock &MBB : MF) {`
`96`	`96`	`for (MachineInstr &MI : MBB) {`
`97`		`- if (MI.getOpcode() == AMDGPU::V_MOV_B32_e32 \|\|`
`98`		`- MI.getOpcode() == AMDGPU::V_ACCVGPR_WRITE_B32_e64) {`
`99`		`- if (TII.isInlineConstant(MI, 1)) {`
`100`		`- MI.setDesc(AVImmPseudo);`
`101`		`- Changed = true;`
`102`		`- }`
	`97`	`+ if ((MI.getOpcode() == AMDGPU::V_MOV_B32_e32 &&`
	`98`	`+ TII.isInlineConstant(MI, 1)) \|\|`
	`99`	`+ (MI.getOpcode() == AMDGPU::V_ACCVGPR_WRITE_B32_e64 &&`
	`100`	`+ MI.getOperand(1).isImm())) {`
	`101`	`+ MI.setDesc(AVImmPseudo);`
	`102`	`+ Changed = true;`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`	`}`