Address David's remaining feedback

Author: JDevlieghere

lldb/docs/resources/lldbgdbremote.md

@@ -2000,16 +2000,19 @@ correctly.
 
 ## qWasmCallStack
 
-Get the Wasm callback for the given thread id. This returns a hex-encoding list
-of 64-bit addresses for the frame PCs. To match the Wasm specification, the
-addresses are encoded in little endian byte order.
+Get the Wasm call stack for the given thread id. This returns a hex-encoded
+list of PC values, one for each frame of the call stack. To match the Wasm
+specification, the addresses are encoded in little endian byte order, even if
+the endian of the Wasm runtime's host is not little endian.
 
 ```
 send packet: $qWasmCallStack:202dbe040#08
 read packet: $9c01000000000040e501000000000040fe01000000000040#
 ```
 
-**Priority to Implement:** Only required for WebAssembly support.
+**Priority to Implement:** Only required for Wasm support. This packed is
+supported by the [WAMR](https://github.com/bytecodealliance/wasm-micro-runtime)
+and [V8](https://v8.dev) Wasm runtimes.
 
 ## qWatchpointSupportInfo
 

lldb/source/Plugins/Process/wasm/ProcessWasm.cpp

@@ -24,8 +24,10 @@ LLDB_PLUGIN_DEFINE(ProcessWasm)
 
 ProcessWasm::ProcessWasm(lldb::TargetSP target_sp, ListenerSP listener_sp)
     : ProcessGDBRemote(target_sp, listener_sp) {
-  // Always use Linux signals for Wasm process.
-  m_unix_signals_sp = UnixSignals::Create(ArchSpec{"wasm32-unknown-wasi-wasm"});
+  assert(target_sp);
+  // Wasm doesn't have any Unix-like signals as a platform concept, but pretend
+  // like it does to appease LLDB.
+  m_unix_signals_sp = UnixSignals::Create(target_sp->GetArchitecture());
 }
 
 void ProcessWasm::Initialize() {

lldb/source/Plugins/Process/wasm/ProcessWasm.h

@@ -17,7 +17,7 @@ namespace wasm {
 /// Each WebAssembly module has separated address spaces for Code and Memory.
 /// A WebAssembly module also has a Data section which, when the module is
 /// loaded, gets mapped into a region in the module Memory.
-enum WasmAddressType { Memory = 0x00, Object = 0x01, Invalid = 0x03 };
+enum WasmAddressType : uint8_t { Memory = 0x00, Object = 0x01, Invalid = 0xff };
 
 /// For the purpose of debugging, we can represent all these separated 32-bit
 /// address spaces with a single virtual 64-bit address space. The

lldb/source/Plugins/Process/wasm/UnwindWasm.cpp

@@ -28,7 +28,7 @@ class WasmGDBRemoteRegisterContext : public GDBRemoteRegisterContext {
                                  false) {
     // Wasm does not have a fixed set of registers but relies on a mechanism
     // named local and global variables to store information such as the stack
-    // pointer.
+    // pointer. The only actual register is the PC.
     PrivateSetRegisterValue(0, pc);
   }
 };