Skip to content

feat: don't open action-url if notification onClick handler returns false #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2023
Merged

feat: don't open action-url if notification onClick handler returns false #62

merged 5 commits into from
Mar 26, 2023

Conversation

pianomansam
Copy link
Contributor

@pianomansam pianomansam commented Mar 21, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Mar 21, 2023

@pianomansam is attempting to deploy a commit to the Magicbell Team on Vercel.

A member of the Team first needs to authorize it.

smeijer
smeijer approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@smeijer smeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks.

Can you also run yarn changeset, flag the react package as patch, and commit those files? Then our CI will pick up the change and publish a new version. 🙂

If not, no problem. I can do it later.

@vercel
Copy link

vercel bot commented Mar 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 26, 2023 at 11:36AM (UTC)

@pianomansam
Copy link
Contributor Author

@smeijer I think I'll let you handle the yarn changeset workflow as I'm not familiar with how you have it all set up.

@smeijer smeijer changed the title Update ClickableNotification handleClick to only run openActionUrl if onClick returns true feat: don't open action-url if notification onClick handler returns false Mar 23, 2023
@smeijer smeijer merged commit 2d96a3d into magicbell:main Mar 26, 2023
@github-actions github-actions bot mentioned this pull request Mar 26, 2023
Merged
@smeijer
Copy link
Member

smeijer commented Mar 26, 2023

This has been released as @magicbell/magicbell-react@10.5.0 and @magicbell/embeddable@3.2.9.

Thanks again for the contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeijer smeijer smeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClickableNotification still performs openActionUrl, even with custom onNotificationClick
2 participants
@pianomansam @smeijer