Finalize other assets and liabilities view (#1264)

Author: zachgoll

app/helpers/accounts_helper.rb

@@ -55,6 +55,7 @@ def account_tabs(account)
     transactions_tab = { key: "transactions", label: t("accounts.show.transactions"), path: account_path(account, tab: "transactions"), route: account_transactions_path(account) }
     trades_tab       = { key: "trades", label: t("accounts.show.trades"), path: account_path(account, tab: "trades"), route: account_trades_path(account) }
 
+    return [ value_tab ] if account.other_asset? || account.other_liability?
     return [ overview_tab, value_tab ] if account.property? || account.vehicle?
     return [ holdings_tab, cash_tab, trades_tab ] if account.investment?
 

app/views/accounts/show.html.erb

@@ -14,7 +14,7 @@
     </div>
     <div class="flex items-center gap-3">
       <%= button_to sync_account_path(@account), method: :post, class: "flex items-center gap-2", title: "Sync Account" do %>
-        <%= lucide_icon "refresh-cw", class: "w-4 h-4 text-gray-900 hover:text-gray-500" %>
+        <%= lucide_icon "refresh-cw", class: "w-4 h-4 text-gray-500 hover:text-gray-400" %>
       <% end %>
 
       <%= contextual_menu do %>

config/locales/views/account/valuations/en.yml

@@ -11,7 +11,7 @@ en:
         date: date
         new_entry: New entry
         no_valuations: No valuations for this account yet
-        valuations: Value history
+        valuations: Value
         value: value
       valuation:
         confirm_accept: Delete entry