Remove missing prices issue (#1390)

Author: zachgoll

app/models/account/holding/syncer.rb

@@ -68,8 +68,6 @@ def build_holdings_for_date(date)
 
         price = get_cached_price(ticker, date) || trade_price
 
-        account.observe_missing_price(ticker:, date:) unless price
-
         account.holdings.build \
           date: date,
           security_id: holding[:security_id],

app/models/concerns/issuable.rb

@@ -33,12 +33,6 @@ def observe_missing_exchange_rate_provider
     )
   end
 
-  def observe_missing_price(ticker:, date:)
-    issue = issues.find_or_create_by(type: Issue::PricesMissing.name, resolved_at: nil)
-    issue.append_missing_price(ticker, date)
-    issue.save!
-  end
-
   def highest_priority_issue
     issues.active.ordered.first
   end

app/models/issue/prices_missing.rb

@@ -0,0 +1,9 @@
+class RemovePricesMissingIssue < ActiveRecord::Migration[7.2]
+  def up
+    execute "DELETE FROM issues WHERE type = 'Issue::PricesMissing'"
+  end
+
+  def down
+    # Cannot restore deleted issues since we don't have the original data
+  end
+end

db/migrate/20241029184115_remove_prices_missing_issue.rb

@@ -85,8 +85,6 @@ class Account::Holding::SyncerTest < ActiveSupport::TestCase
                    .once
                    .returns(fetched_prices)
 
-    @account.expects(:observe_missing_price).with(ticker: "AMZN", date: Date.current).once
-
     run_sync_for(@account)
 
     assert_holdings(expected)

db/schema.rb

@@ -89,12 +89,4 @@ class AccountTest < ActiveSupport::TestCase
     assert_equal 10, account.holding_qty(security, date: 1.day.ago.to_date)
     assert_equal 0, account.holding_qty(security, date: 2.days.ago.to_date)
   end
-
-  test "can observe missing price" do
-    account = accounts(:investment)
-
-    assert_difference -> { account.issues.count } do
-      account.observe_missing_price(ticker: "AAPL", date: Date.current)
-    end
-  end
 end