From 76dded3c5114412e34d571cfaeddadb2f33d0579 Mon Sep 17 00:00:00 2001 From: Konrad Weihmann Date: Tue, 7 Jul 2020 13:00:33 +0200 Subject: [PATCH] fix format-truncation on 64bit GCC 10.x rightfully complains about out-of-bounds snprintf operation on 64bit systems, where size_t could be 64bit sized. Cast bytes_read down to 32bit and printf it without specifying input format Signed-off-by: Konrad Weihmann --- Release/src/http/common/http_helpers.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Release/src/http/common/http_helpers.cpp b/Release/src/http/common/http_helpers.cpp index 9ffbd20dd0..1a52c81adf 100644 --- a/Release/src/http/common/http_helpers.cpp +++ b/Release/src/http/common/http_helpers.cpp @@ -88,7 +88,7 @@ size_t chunked_encoding::add_chunked_delimiters(_Out_writes_(buffer_size) uint8_ #ifdef _WIN32 sprintf_s(buffer, sizeof(buffer), "%8IX", bytes_read); #else - snprintf(buffer, sizeof(buffer), "%8zX", bytes_read); + snprintf(buffer, sizeof(buffer), "%8X", static_cast(bytes_read)); #endif memcpy(&data[0], buffer, 8); while (data[offset] == ' ')