Skip to content

Commit 735e064

Browse files
fix(Grist Node): Test for integer precision loss (#17136)
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
1 parent f0a4ecd commit 735e064

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/nodes-base/nodes/Grist/GenericFunctions.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,14 @@ export function parseSortProperties(sortProperties: GristSortProperties) {
6767
}, '');
6868
}
6969

70+
export function isSafeInteger(val: number) {
71+
return !isNaN(val) && val > Number.MIN_VALUE && val < Number.MAX_VALUE;
72+
}
73+
7074
export function parseFilterProperties(filterProperties: GristFilterProperties) {
7175
return filterProperties.reduce<{ [key: string]: Array<string | number> }>((acc, cur) => {
7276
acc[cur.field] = acc[cur.field] ?? [];
73-
const values = isNaN(Number(cur.values)) ? cur.values : Number(cur.values);
77+
const values = isSafeInteger(Number(cur.values)) ? Number(cur.values) : cur.values;
7478
acc[cur.field].push(values);
7579
return acc;
7680
}, {});

0 commit comments

Comments
 (0)