Skip to content

Commit c76c689

Browse files
theatischbeinjuliusknorr
authored andcommitted
Sidebar: removed
Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
1 parent 82cdecb commit c76c689

File tree

7 files changed

+4
-327
lines changed

7 files changed

+4
-327
lines changed

src/App.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@
3737
</div>
3838
</NcAppContent>
3939
<router-view v-else @note-deleted="onNoteDeleted" />
40-
41-
<router-view name="sidebar" />
4240
</NcContent>
4341
</template>
4442

src/components/NoteItem.vue

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929
<NcActionButton :icon="actionFavoriteIcon" @click="onToggleFavorite">
3030
{{ actionFavoriteText }}
3131
</NcActionButton>
32-
<NcActionButton @click="onToggleSidebar">
33-
<SidebarIcon slot="icon" :size="20" />
34-
{{ t('notes', 'Details') }}
35-
</NcActionButton>
3632
<NcActionButton v-if="!note.readonly" :icon="actionDeleteIcon" @click="onDeleteNote">
3733
{{ t('notes', 'Delete note') }}
3834
</NcActionButton>
@@ -45,14 +41,12 @@
4541
</template>
4642

4743
<script>
48-
import { NcListItem, NcActionButton } from '@nextcloud/vue'
44+
import { NcListItem, NcActionButton, NcActionSeparator } from '@nextcloud/vue'
4945
import AlertOctagonIcon from 'vue-material-design-icons/AlertOctagon.vue'
5046
import FileDocumentOutlineIcon from 'vue-material-design-icons/FileDocumentOutline.vue'
5147
import StarIcon from 'vue-material-design-icons/Star.vue'
52-
import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
5348
import { categoryLabel, routeIsNewNote } from '../Util.js'
5449
import { showError } from '@nextcloud/dialogs'
55-
import store from '../store.js'
5650
import { setFavorite, setTitle, fetchNote, deleteNote } from '../NotesService.js'
5751
5852
export default {
@@ -63,8 +57,8 @@ export default {
6357
FileDocumentOutlineIcon,
6458
NcActionButton,
6559
NcListItem,
66-
SidebarIcon,
6760
StarIcon,
61+
NcActionSeparator,
6862
},
6963
7064
props: {
@@ -131,10 +125,6 @@ export default {
131125
this.actionsOpen = false
132126
this.$emit('category-selected', this.note.category)
133127
},
134-
onToggleSidebar() {
135-
this.actionsOpen = false
136-
store.commit('setSidebarOpen', !store.state.app.sidebarOpen)
137-
},
138128
onRename(newTitle) {
139129
this.loading.note = true
140130
setTitle(this.note.id, newTitle)

src/components/NotePlain.vue

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<NcAppContent :class="{ loading: loading || isManualSave, 'icon-error': !loading && (!note || note.error), 'sidebar-open': sidebarOpen }">
2+
<NcAppContent :class="{ loading: loading || isManualSave, 'icon-error': !loading && (!note || note.error)}">
33
<div v-if="!loading && note && !note.error && !note.deleting"
44
id="note-container"
55
class="note-container"
@@ -47,13 +47,6 @@
4747
</div>
4848
<span class="action-buttons">
4949
<NcActions :open.sync="actionsOpen" container=".action-buttons" menu-align="right">
50-
<NcActionButton v-show="!sidebarOpen && !fullscreen"
51-
icon="icon-details"
52-
@click="onToggleSidebar"
53-
>
54-
<SidebarIcon slot="icon" :size="20" />
55-
{{ t('notes', 'Details') }}
56-
</NcActionButton>
5750
<NcActionButton
5851
v-tooltip.left="t('notes', 'CTRL + /')"
5952
@click="onTogglePreview"
@@ -109,7 +102,6 @@ import EditIcon from 'vue-material-design-icons/LeadPencil.vue'
109102
import EyeIcon from 'vue-material-design-icons/Eye.vue'
110103
import FullscreenIcon from 'vue-material-design-icons/Fullscreen.vue'
111104
import NoEditIcon from 'vue-material-design-icons/PencilOff.vue'
112-
import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
113105
import SyncAlertIcon from 'vue-material-design-icons/SyncAlert.vue'
114106
115107
import { config } from '../config.js'
@@ -133,7 +125,6 @@ export default {
133125
NcAppContent,
134126
NcModal,
135127
NoEditIcon,
136-
SidebarIcon,
137128
SyncAlertIcon,
138129
TheEditor,
139130
ThePreview,
@@ -179,9 +170,6 @@ export default {
179170
isManualSave() {
180171
return store.state.app.isManualSave
181172
},
182-
sidebarOpen() {
183-
return store.state.app.sidebarOpen
184-
},
185173
},
186174
187175
watch: {
@@ -293,11 +281,6 @@ export default {
293281
this.actionsOpen = false
294282
},
295283
296-
onToggleSidebar() {
297-
store.commit('setSidebarOpen', !store.state.app.sidebarOpen)
298-
this.actionsOpen = false
299-
},
300-
301284
onVisibilityChange() {
302285
if (document.visibilityState === 'visible') {
303286
this.stopRefreshTimer()
@@ -436,9 +419,6 @@ export default {
436419
transition-duration: var(--animation-quick);
437420
transition-property: padding-right;
438421
}
439-
.sidebar-open .note-container {
440-
padding-right: 0px;
441-
}
442422
}
443423
444424
/* distraction free styles */

src/components/NoteRich.vue

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<div class="text-editor-wrapper" :class="{ loading: loading, 'icon-error': !loading && (!note || note.error), 'sidebar-open': sidebarOpen, 'is-mobile': isMobile }">
2+
<div class="text-editor-wrapper" :class="{ loading: loading, 'icon-error': !loading && (!note || note.error), 'is-mobile': isMobile }">
33
<div v-show="!loading" ref="editor" class="text-editor" />
44
</div>
55
</template>
@@ -41,9 +41,6 @@ export default {
4141
isNewNote() {
4242
return routeIsNewNote(this.$route)
4343
},
44-
sidebarOpen() {
45-
return store.state.app.sidebarOpen
46-
},
4744
},
4845
4946
watch: {

0 commit comments

Comments
 (0)