Skip to content

Commit 195d603

Browse files
joyeecheungaduh95
authored andcommitted
tools: clarify README linter error message
PR-URL: #59160 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent a0d22e9 commit 195d603

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tools/lint-readme-lists.mjs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import assert from 'node:assert';
66
import { open } from 'node:fs/promises';
77
import { argv } from 'node:process';
88

9-
const ghHandleLine = /^\* \[(.+)\]\(https:\/\/github\.com\/\1\) -$/;
9+
const ghHandleLine = /^\* \[(.+)\]\(https:\/\/github\.com\/(.+)\) -$/;
1010
const memberInfoLine = /^ {2}\*\*[^*]+\*\* <<[^@]+@.+\.[a-z]+>>( \(\w+(\/[^)/]+)+\))?( - \[Support me\]\(.+\))?$/;
1111

1212
const lists = {
@@ -59,9 +59,11 @@ for await (const line of readme.readLines()) {
5959
);
6060
}
6161

62-
if (!ghHandleLine.test(line)) {
63-
throw new Error(`${currentGithubHandle} is not formatted correctly (README.md:${lineNumber})`);
62+
const match = line.match(ghHandleLine);
63+
if (!match) {
64+
throw new Error(`${line} should match ${ghHandleLine} (README.md:${lineNumber})`);
6465
}
66+
assert.strictEqual(match[1], match[2], `GitHub handle does not match the URL (README.md:${lineNumber})`);
6567

6668
if (
6769
currentList === 'TSC voting members' ||

0 commit comments

Comments
 (0)