Skip to content

Commit a0d22e9

Browse files
joyeecheungaduh95
authored andcommitted
test: remove timeout in test-https-proxy-request-handshake-failure
The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second. PR-URL: #59165 Fixes: #59166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 28538f2 commit a0d22e9

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

test/client-proxy/test-https-proxy-request-handshake-failure.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const requestUrl = `https://${serverHost}/test`;
3333
const { code, signal, stderr, stdout } = await runProxiedRequest({
3434
NODE_USE_ENV_PROXY: 1,
3535
REQUEST_URL: requestUrl,
36-
REQUEST_TIMEOUT: 1000,
3736
HTTPS_PROXY: `http://localhost:${proxy.address().port}`,
3837
});
3938

0 commit comments

Comments
 (0)