Skip to content

Commit d5892b5

Browse files
dependabot[bot]redallen
dependabot[bot]
and
redallen
authored
chore(deps): bump @patternfly/patternfly from 4.36.1 to 4.42.2 (#4833)
* chore(deps): bump @patternfly/patternfly from 4.36.1 to 4.42.0 Bumps [@patternfly/patternfly](https://github.com/patternfly/patternfly) from 4.36.1 to 4.42.0. - [Release notes](https://github.com/patternfly/patternfly/releases) - [Changelog](https://github.com/patternfly/patternfly/blob/master/RELEASE-NOTES.md) - [Commits](patternfly/patternfly@prerelease-v4.36.1...prerelease-v4.42.0) Signed-off-by: dependabot[bot] <support@github.com> * fix treeview removed class * use node 12 * bump to 4.42.2 * add aria-labels to button Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: redallen <zallen@redhat.com>
1 parent c117ae4 commit d5892b5

File tree

14 files changed

+108
-89
lines changed

14 files changed

+108
-89
lines changed

‎.circleci/config.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ references:
5252
at: ~/project
5353
install_node: &install_node
5454
run:
55-
name: Install node@10 (need right version for `yarn`)
55+
name: Install node@12 (need right version for `yarn`)
5656
command: |
5757
set +e
5858
curl -o- https://raw.github.com/creationix/nvm/v0.33.5/install.sh | bash
5959
export NVM_DIR="/opt/circleci/.nvm"
6060
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
61-
nvm install v10
62-
nvm alias default v10
61+
nvm install v12
62+
nvm alias default v12
6363
6464
# Each step uses the same `$BASH_ENV`, so need to modify it
6565
echo 'export NVM_DIR="/opt/circleci/.nvm"' >> $BASH_ENV
@@ -103,7 +103,7 @@ workflows:
103103
jobs:
104104
build_pf4:
105105
docker:
106-
- image: circleci/node:10
106+
- image: circleci/node:12
107107
steps:
108108
- checkout
109109
- persist_to_workspace:
@@ -137,7 +137,7 @@ jobs:
137137
paths: *build_cache_paths
138138
test_jest_pf4:
139139
docker:
140-
- image: circleci/node:10
140+
- image: circleci/node:12
141141
steps:
142142
- *attach_workspace
143143
- restore_cache:
@@ -152,7 +152,7 @@ jobs:
152152
when: always
153153
build_demo_app:
154154
docker:
155-
- image: circleci/node:10
155+
- image: circleci/node:12
156156
steps:
157157
- *attach_workspace
158158
- restore_cache:
@@ -167,7 +167,7 @@ jobs:
167167
- packages/react-integration/demo-app-ts/build/
168168
test_integration:
169169
docker:
170-
- image: circleci/node:10
170+
- image: circleci/node:12
171171
parallelism: 3
172172
steps:
173173
- *attach_workspace
@@ -196,7 +196,7 @@ jobs:
196196
path: packages/react-integration/results
197197
lint_pf4:
198198
docker:
199-
- image: circleci/node:10
199+
- image: circleci/node:12
200200
steps:
201201
- *attach_workspace
202202
- restore_cache:
@@ -255,7 +255,7 @@ jobs:
255255
paths: *gatsby_cache_paths
256256
test_a11y_pf4:
257257
docker:
258-
- image: circleci/node:10-browsers
258+
- image: circleci/node:12-browsers
259259
steps:
260260
- *attach_workspace
261261
- restore_cache:
@@ -276,7 +276,7 @@ jobs:
276276
path: packages/react-docs/coverage/
277277
deploy_prerelease:
278278
docker:
279-
- image: circleci/node:10
279+
- image: circleci/node:12
280280
steps:
281281
- *attach_workspace
282282
- restore_cache:

‎packages/react-catalog-view-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"clean": "rimraf dist"
3636
},
3737
"dependencies": {
38-
"@patternfly/patternfly": "4.36.1",
38+
"@patternfly/patternfly": "4.42.2",
3939
"@patternfly/react-core": "^4.50.0",
4040
"@patternfly/react-styles": "^4.7.4",
4141
"classnames": "^2.2.5",

‎packages/react-charts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"homepage": "https://github.com/patternfly/patternfly-react#readme",
3131
"dependencies": {
32-
"@patternfly/patternfly": "4.36.1",
32+
"@patternfly/patternfly": "4.42.2",
3333
"@patternfly/react-styles": "^4.7.4",
3434
"@patternfly/react-tokens": "^4.9.7",
3535
"hoist-non-react-statics": "^3.3.0",

‎packages/react-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"tslib": "^1.11.1"
4545
},
4646
"devDependencies": {
47-
"@patternfly/patternfly": "4.36.1",
47+
"@patternfly/patternfly": "4.42.2",
4848
"@rollup/plugin-commonjs": "^11.0.2",
4949
"@rollup/plugin-node-resolve": "^7.1.1",
5050
"@rollup/plugin-replace": "^2.3.1",

‎packages/react-core/src/components/TreeView/TreeViewListItem.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ export const TreeViewListItem: React.FunctionComponent<TreeViewListItemProps> =
9393
activeItems &&
9494
activeItems.length > 0 &&
9595
activeItems.some(item => compareItems && item && compareItems(item, itemData))
96-
? children
97-
? styles.modifiers.active
98-
: styles.modifiers.current
96+
? styles.modifiers.current
9997
: ''
10098
)}
10199
onClick={(evt: React.MouseEvent) => {

‎packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeView.test.tsx.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ exports[`tree view renders active successfully 1`] = `
492492
className="pf-c-tree-view__content"
493493
>
494494
<button
495-
className="pf-c-tree-view__node pf-m-active"
495+
className="pf-c-tree-view__node pf-m-current"
496496
onClick={[Function]}
497497
>
498498
<span
@@ -1499,7 +1499,7 @@ exports[`tree view renders badges successfully 1`] = `
14991499
className="pf-c-tree-view__content"
15001500
>
15011501
<button
1502-
className="pf-c-tree-view__node pf-m-active"
1502+
className="pf-c-tree-view__node pf-m-current"
15031503
onClick={[Function]}
15041504
>
15051505
<span
@@ -3417,7 +3417,7 @@ exports[`tree view renders checkboxes successfully 1`] = `
34173417
className="pf-c-tree-view__content"
34183418
>
34193419
<button
3420-
className="pf-c-tree-view__node pf-m-active"
3420+
className="pf-c-tree-view__node pf-m-current"
34213421
onClick={[Function]}
34223422
>
34233423
<span
@@ -4544,7 +4544,7 @@ exports[`tree view renders icons successfully 1`] = `
45444544
className="pf-c-tree-view__content"
45454545
>
45464546
<button
4547-
className="pf-c-tree-view__node pf-m-active"
4547+
className="pf-c-tree-view__node pf-m-current"
45484548
onClick={[Function]}
45494549
>
45504550
<span
@@ -5845,7 +5845,7 @@ exports[`tree view renders individual flag options successfully 1`] = `
58455845
className="pf-c-tree-view__content"
58465846
>
58475847
<button
5848-
className="pf-c-tree-view__node pf-m-active"
5848+
className="pf-c-tree-view__node pf-m-current"
58495849
onClick={[Function]}
58505850
>
58515851
<span
@@ -6961,7 +6961,7 @@ exports[`tree view renders search successfully 1`] = `
69616961
className="pf-c-tree-view__content"
69626962
>
69636963
<button
6964-
className="pf-c-tree-view__node pf-m-active"
6964+
className="pf-c-tree-view__node pf-m-current"
69656965
onClick={[Function]}
69666966
>
69676967
<span

‎packages/react-core/src/components/TreeView/examples/TreeView.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,17 +611,26 @@ class IconTreeView extends React.Component {
611611
name: 'ApplicationLauncher',
612612
id: 'AppLaunch',
613613
action: <EllipsisVIcon />,
614+
actionProps: {
615+
'aria-label': 'Launch app'
616+
},
614617
children: [
615618
{
616619
name: 'Application 1',
617620
id: 'App1',
618621
action: <ClipboardIcon />,
622+
actionProps: {
623+
'aria-label': 'Launch app 1'
624+
},
619625
children: [{ name: 'Settings', id: 'App1Settings' }, { name: 'Current', id: 'App1Current' }]
620626
},
621627
{
622628
name: 'Application 2',
623629
id: 'App2',
624630
action: <HamburgerIcon />,
631+
actionProps: {
632+
'aria-label': 'Launch app 2'
633+
},
625634
children: [
626635
{ name: 'Settings', id: 'App2Settings' },
627636
{

‎packages/react-docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:a11y": "patternfly-a11y --file .cache/fullscreenPages.json --prefix http://localhost:9000 --aggregate --noIncomplete --ignore color-contrast,focusable-content,scrollable-region-focusable --skip \"charts|virtualizedtable/selectable\""
2424
},
2525
"dependencies": {
26-
"@patternfly/patternfly": "4.36.1",
26+
"@patternfly/patternfly": "4.42.2",
2727
"@patternfly/react-catalog-view-extension": "^4.8.29",
2828
"@patternfly/react-charts": "^6.9.7",
2929
"@patternfly/react-core": "^4.50.0",

‎packages/react-icons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"@fortawesome/free-brands-svg-icons": "^5.7.2",
3333
"@fortawesome/free-regular-svg-icons": "^5.7.2",
3434
"@fortawesome/free-solid-svg-icons": "^5.7.2",
35-
"@patternfly/patternfly": "4.36.1",
35+
"@patternfly/patternfly": "4.42.2",
3636
"fs-extra": "^6.0.1",
3737
"glob": "^7.1.2",
3838
"rimraf": "^2.6.2",

‎packages/react-integration/cypress/integration/treeview.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('TreeView Demo Test', () => {
99
cy.get('#basic').should('exist');
1010
cy.get('#App1').should('exist');
1111
cy.get('#App1').click();
12-
cy.get('#App1 .pf-c-tree-view__node').should('have.class', 'pf-m-active');
12+
cy.get('#App1 .pf-c-tree-view__node').should('have.class', 'pf-m-current');
1313
cy.get('#App1Settings').should('exist');
1414
cy.get('#App1Settings').click();
1515
cy.get('#App1Settings .pf-c-tree-view__node').should('have.class', 'pf-m-current');

0 commit comments

Comments
 (0)