Skip to content

[RFC] Deprecate xml_parser_free() #19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

[RFC] Deprecate xml_parser_free() #19449

merged 1 commit into from
Aug 12, 2025
+29 −38

Conversation

DanielEScherzer
Copy link
Member

@DanielEScherzer DanielEScherzer commented Aug 11, 2025 •
edited by Girgias
Loading

@DanielEScherzer DanielEScherzer requested review from Girgias and removed request for kocsismate and nielsdos August 11, 2025 17:30
@DanielEScherzer
Copy link
Member Author

To avoid merge conflicts, NEWS/UPGRADING will be sent once this is approved

@TimWolla TimWolla added the RFC label Aug 12, 2025
@Girgias
Copy link
Member

Girgias commented Aug 12, 2025

Do we want to address the same remark as #19454 (review) ?

@DanielEScherzer
Copy link
Member Author

Do we want to address the same remark as #19454 (review) ?

Not right now, but can be addressed in a subsequent commit

@DanielEScherzer DanielEScherzer merged commit 4de2ec3 into php:master Aug 12, 2025
15 of 16 checks passed
@DanielEScherzer DanielEScherzer deleted the xml_parser_free branch August 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: libxml Extension: xml RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielEScherzer @Girgias @nielsdos @TimWolla